Skip to content

Commit be2f928

Browse files
innovaralag-linaro
authored andcommitted
leds: Kconfig: leds-st1202: Add select for required LEDS_TRIGGER_PATTERN
leds-st1202 requires the LED Pattern Trigger (LEDS_TRIGGER_PATTERN), which is not selected when LED Trigger support is (LEDS_TRIGGERS). To reproduce this: - make menuconfig KCONFIG_CONFIG= - select LEDS_ST1202 dependencies OF, I2C and LEDS_CLASS. - select LEDS_ST1202 - LEDS_TRIGGERS is selected but LEDS_TRIGGER_PATTERN isn't. The absence of LEDS_TRIGGER_PATTERN explicitly required can lead to builds in which LEDS_ST1202 is selected while LEDS_TRIGGER_PATTERN isn't. The direct result of that would be that /sys/class/leds/<led>/hw_pattern wouldn't be available and there would be no way of interacting with the driver and hardware from user space. Add select LEDS_TRIGGER_PATTERN to Kconfig to meet the requirement and indirectly document it as well. Signed-off-by: Manuel Fombuena <[email protected]> Link: https://lore.kernel.org/r/CWLP123MB5473F4DF3A668F7DD057A280C5C22@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM Signed-off-by: Lee Jones <[email protected]>
1 parent 5d0e481 commit be2f928

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/leds/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -971,6 +971,7 @@ config LEDS_ST1202
971971
depends on I2C
972972
depends on OF
973973
select LEDS_TRIGGERS
974+
select LEDS_TRIGGER_PATTERN
974975
help
975976
Say Y to enable support for LEDs connected to LED1202
976977
LED driver chips accessed via the I2C bus.

0 commit comments

Comments
 (0)