HID: uhid: Fix returning EPOLLOUT from uhid_char_poll

holtmann · Jiri Kosina · commit be54e7461ffd · 2019-12-09T13:53:37.000+01:00
Always return EPOLLOUT from uhid_char_poll to allow polling /dev/uhid for writable state. Fixes: 1f9dec1 ("HID: uhid: allow poll()'ing on uhid devices") Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Cc: stable@vger.kernel.org Signed-off-by: Jiri Kosina <jkosina@suse.cz>
diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
@@ -772,7 +772,7 @@ static __poll_t uhid_char_poll(struct file *file, poll_table *wait)
 	if (uhid->head != uhid->tail)
 		return EPOLLIN | EPOLLRDNORM;
 
-	return 0;
+	return EPOLLOUT | EPOLLWRNORM;
 }
 
 static const struct file_operations uhid_fops = {

Original file line number	Diff line number	Diff line change
`@@ -772,7 +772,7 @@ static __poll_t uhid_char_poll(struct file file, poll_table wait)`
`772`	`772`	`if (uhid->head != uhid->tail)`
`773`	`773`	`return EPOLLIN \| EPOLLRDNORM;`
`774`	`774`
`775`		`- return 0;`
	`775`	`+ return EPOLLOUT \| EPOLLWRNORM;`
`776`	`776`	`}`
`777`	`777`
`778`	`778`	`static const struct file_operations uhid_fops = {`