Skip to content

Commit be59167

Browse files
committed
afs: Remove some unused bits
Remove three bits: (1) afs_server::no_epoch is neither set nor used. (2) afs_server::have_result is set and a wakeup is applied to it, but nothing looks at it or waits on it. (3) afs_vl_dump_edestaddrreq() prints afs_addr_list::probed, but nothing sets it for VL servers. Signed-off-by: David Howells <[email protected]>
1 parent ae83d0b commit be59167

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

fs/afs/fs_probe.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,8 @@ void afs_fileserver_probe_result(struct afs_call *call)
117117
(unsigned int)rtt, ret);
118118

119119
have_result |= afs_fs_probe_done(server);
120-
if (have_result) {
121-
server->probe.have_result = true;
122-
wake_up_var(&server->probe.have_result);
120+
if (have_result)
123121
wake_up_all(&server->probe_wq);
124-
}
125122
}
126123

127124
/*

fs/afs/internal.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -533,12 +533,10 @@ struct afs_server {
533533
u32 abort_code;
534534
u32 cm_epoch;
535535
short error;
536-
bool have_result;
537536
bool responded:1;
538537
bool is_yfs:1;
539538
bool not_yfs:1;
540539
bool local_failure:1;
541-
bool no_epoch:1;
542540
bool cm_probed:1;
543541
bool said_rebooted:1;
544542
bool said_inconsistent:1;

fs/afs/vl_rotate.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,8 +302,8 @@ static void afs_vl_dump_edestaddrreq(const struct afs_vl_cursor *vc)
302302
pr_notice("VC: - nr=%u/%u/%u pf=%u\n",
303303
a->nr_ipv4, a->nr_addrs, a->max_addrs,
304304
a->preferred);
305-
pr_notice("VC: - pr=%lx R=%lx F=%lx\n",
306-
a->probed, a->responded, a->failed);
305+
pr_notice("VC: - R=%lx F=%lx\n",
306+
a->responded, a->failed);
307307
if (a == vc->ac.alist)
308308
pr_notice("VC: - current\n");
309309
}

0 commit comments

Comments
 (0)