Skip to content

Commit be87cb7

Browse files
charleskeepaxchanwoochoi
authored andcommitted
extcon: arizona: Move pdata extraction to probe
It makes no sense to be extracting values from pdata for the first time in the jack detection handler function, move this to probe time where it belongs. Signed-off-by: Charles Keepax <[email protected]> Signed-off-by: Chanwoo Choi <[email protected]>
1 parent b82f871 commit be87cb7

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

drivers/extcon/extcon-arizona.c

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ struct arizona_extcon_info {
7777
const struct arizona_micd_range *micd_ranges;
7878
int num_micd_ranges;
7979

80-
int micd_timeout;
81-
8280
bool micd_reva;
8381
bool micd_clamp;
8482

@@ -1016,7 +1014,7 @@ static void arizona_micd_detect(struct work_struct *work)
10161014

10171015
queue_delayed_work(system_power_efficient_wq,
10181016
&info->micd_timeout_work,
1019-
msecs_to_jiffies(info->micd_timeout));
1017+
msecs_to_jiffies(arizona->pdata.micd_timeout));
10201018
}
10211019

10221020
pm_runtime_mark_last_busy(info->dev);
@@ -1136,7 +1134,7 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
11361134
msecs_to_jiffies(HPDET_DEBOUNCE));
11371135

11381136
if (cancelled_mic) {
1139-
int micd_timeout = info->micd_timeout;
1137+
int micd_timeout = arizona->pdata.micd_timeout;
11401138

11411139
queue_delayed_work(system_power_efficient_wq,
11421140
&info->micd_timeout_work,
@@ -1213,11 +1211,6 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
12131211
ARIZONA_MICD_CLAMP_DB | ARIZONA_JD1_DB);
12141212
}
12151213

1216-
if (arizona->pdata.micd_timeout)
1217-
info->micd_timeout = arizona->pdata.micd_timeout;
1218-
else
1219-
info->micd_timeout = DEFAULT_MICD_TIMEOUT;
1220-
12211214
out:
12221215
/* Clear trig_sts to make sure DCVDD is not forced up */
12231216
regmap_write(arizona->regmap, ARIZONA_AOD_WKUP_AND_TRIG,
@@ -1446,6 +1439,9 @@ static int arizona_extcon_probe(struct platform_device *pdev)
14461439
info->input->name = "Headset";
14471440
info->input->phys = "arizona/extcon";
14481441

1442+
if (!pdata->micd_timeout)
1443+
pdata->micd_timeout = DEFAULT_MICD_TIMEOUT;
1444+
14491445
if (pdata->num_micd_configs) {
14501446
info->micd_modes = pdata->micd_configs;
14511447
info->micd_num_modes = pdata->num_micd_configs;

0 commit comments

Comments
 (0)