drm/amdgpu: use %u rather than %d for sclk/mclk

alexdeucher · alexdeucher · commit beaf10efca64 · 2020-07-01T14:20:23.000-04:00
Large clock values may overflow and show up as negative.

Reported by prOMiNd on IRC.

Acked-by: Nirmoy Das &lt;nirmoy.das@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Cc: stable@vger.kernel.org
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
@@ -2784,7 +2784,7 @@ static ssize_t amdgpu_hwmon_show_sclk(struct device *dev,
 	if (r)
 		return r;
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", sclk * 10 * 1000);
+	return snprintf(buf, PAGE_SIZE, "%u\n", sclk * 10 * 1000);
 }
 
 static ssize_t amdgpu_hwmon_show_sclk_label(struct device *dev,
@@ -2819,7 +2819,7 @@ static ssize_t amdgpu_hwmon_show_mclk(struct device *dev,
 	if (r)
 		return r;
 
-	return snprintf(buf, PAGE_SIZE, "%d\n", mclk * 10 * 1000);
+	return snprintf(buf, PAGE_SIZE, "%u\n", mclk * 10 * 1000);
 }
 
 static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,

Original file line number	Diff line number	Diff line change
`@@ -2784,7 +2784,7 @@ static ssize_t amdgpu_hwmon_show_sclk(struct device *dev,`
`2784`	`2784`	`if (r)`
`2785`	`2785`	`return r;`
`2786`	`2786`
`2787`		`- return snprintf(buf, PAGE_SIZE, "%d\n", sclk * 10 * 1000);`
	`2787`	`+ return snprintf(buf, PAGE_SIZE, "%u\n", sclk * 10 * 1000);`
`2788`	`2788`	`}`
`2789`	`2789`
`2790`	`2790`	`static ssize_t amdgpu_hwmon_show_sclk_label(struct device *dev,`
`@@ -2819,7 +2819,7 @@ static ssize_t amdgpu_hwmon_show_mclk(struct device *dev,`
`2819`	`2819`	`if (r)`
`2820`	`2820`	`return r;`
`2821`	`2821`
`2822`		`- return snprintf(buf, PAGE_SIZE, "%d\n", mclk * 10 * 1000);`
	`2822`	`+ return snprintf(buf, PAGE_SIZE, "%u\n", mclk * 10 * 1000);`
`2823`	`2823`	`}`
`2824`	`2824`
`2825`	`2825`	`static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,`