Skip to content

Commit bec8ff1

Browse files
committed
Merge tag 'drm-intel-fixes-2025-06-18' of https://gitlab.freedesktop.org/drm/i915/kernel into drm-fixes
- Fix MIPI vtotal programming off by one on Broxton - Fix PMU code for GCOV and AutoFDO enabled build Signed-off-by: Dave Airlie <[email protected]> From: Joonas Lahtinen <[email protected]> Link: https://lore.kernel.org/r/aFJfykDpUwtmpilE@jlahtine-mobl
2 parents 49a5fdc + c464ce6 commit bec8ff1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

drivers/gpu/drm/i915/display/vlv_dsi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,7 +1056,7 @@ static void bxt_dsi_get_pipe_config(struct intel_encoder *encoder,
10561056
BXT_MIPI_TRANS_VACTIVE(port));
10571057
adjusted_mode->crtc_vtotal =
10581058
intel_de_read(display,
1059-
BXT_MIPI_TRANS_VTOTAL(port));
1059+
BXT_MIPI_TRANS_VTOTAL(port)) + 1;
10601060

10611061
hactive = adjusted_mode->crtc_hdisplay;
10621062
hfp = intel_de_read(display, MIPI_HFP_COUNT(display, port));
@@ -1260,7 +1260,7 @@ static void set_dsi_timings(struct intel_encoder *encoder,
12601260
intel_de_write(display, BXT_MIPI_TRANS_VACTIVE(port),
12611261
adjusted_mode->crtc_vdisplay);
12621262
intel_de_write(display, BXT_MIPI_TRANS_VTOTAL(port),
1263-
adjusted_mode->crtc_vtotal);
1263+
adjusted_mode->crtc_vtotal - 1);
12641264
}
12651265

12661266
intel_de_write(display, MIPI_HACTIVE_AREA_COUNT(display, port),

drivers/gpu/drm/i915/i915_pmu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ static u32 config_mask(const u64 config)
112112
{
113113
unsigned int bit = config_bit(config);
114114

115-
if (__builtin_constant_p(config))
115+
if (__builtin_constant_p(bit))
116116
BUILD_BUG_ON(bit >
117117
BITS_PER_TYPE(typeof_member(struct i915_pmu,
118118
enable)) - 1);
@@ -121,7 +121,7 @@ static u32 config_mask(const u64 config)
121121
BITS_PER_TYPE(typeof_member(struct i915_pmu,
122122
enable)) - 1);
123123

124-
return BIT(config_bit(config));
124+
return BIT(bit);
125125
}
126126

127127
static bool is_engine_event(struct perf_event *event)

0 commit comments

Comments
 (0)