nfsd: fix nfsdfs inode reference count leak

J. Bruce Fields · J. Bruce Fields · commit bf2654017e02 · 2020-06-29T14:48:28.000-04:00
I don't understand this code well, but I'm seeing a warning about a still-referenced inode on unmount, and every other similar filesystem does a dput() here. Fixes: e8a79fb ("nfsd: add nfsd/clients directory") Signed-off-by: J. Bruce Fields <bfields@redhat.com>
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
@@ -1335,6 +1335,7 @@ void nfsd_client_rmdir(struct dentry *dentry)
 	WARN_ON_ONCE(ret);
 	fsnotify_rmdir(dir, dentry);
 	d_delete(dentry);
+	dput(dentry);
 	inode_unlock(dir);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1335,6 +1335,7 @@ void nfsd_client_rmdir(struct dentry *dentry)`
`1335`	`1335`	`WARN_ON_ONCE(ret);`
`1336`	`1336`	`fsnotify_rmdir(dir, dentry);`
`1337`	`1337`	`d_delete(dentry);`
	`1338`	`+ dput(dentry);`
`1338`	`1339`	`inode_unlock(dir);`
`1339`	`1340`	`}`
`1340`	`1341`