Skip to content

Commit bf8bde4

Browse files
ffainelliMarc Zyngier
authored andcommitted
MIPS: BMIPS: Remove use of irq_cpu_offline
irq_cpu_offline() is only used by MIPS and we should instead use irq_migrate_all_off_this_cpu(). This will be helpful in order to remove drivers/irqchip/irq-bcm7038-l1.c irq_cpu_offline callback which would have got in the way of making this driver modular. Suggested-by: Thomas Gleixner <[email protected]> Acked-by: Thomas Bogendoerfer <[email protected]> Signed-off-by: Florian Fainelli <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent dfd8c90 commit bf8bde4

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

arch/mips/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1782,6 +1782,7 @@ config CPU_BMIPS
17821782
select CPU_HAS_PREFETCH
17831783
select CPU_SUPPORTS_CPUFREQ
17841784
select MIPS_EXTERNAL_TIMER
1785+
select GENERIC_IRQ_MIGRATION if HOTPLUG_CPU
17851786
help
17861787
Support for BMIPS32/3300/4350/4380 and BMIPS5000 processors.
17871788

arch/mips/kernel/smp-bmips.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include <linux/bug.h>
2727
#include <linux/kernel.h>
2828
#include <linux/kexec.h>
29+
#include <linux/irq.h>
2930

3031
#include <asm/time.h>
3132
#include <asm/processor.h>
@@ -373,7 +374,7 @@ static int bmips_cpu_disable(void)
373374

374375
set_cpu_online(cpu, false);
375376
calculate_cpu_foreign_map();
376-
irq_cpu_offline();
377+
irq_migrate_all_off_this_cpu();
377378
clear_c0_status(IE_IRQ5);
378379

379380
local_flush_tlb_all();

0 commit comments

Comments
 (0)