Skip to content

Commit bf9f80c

Browse files
jmberg-intelrichardweinberger
authored andcommitted
um: virtio_uml: Disallow modular build
This driver *can* be a module, but then its parameters (socket path) are untrusted data from inside the VM, and that isn't allowed. Allow the code to only be built-in to avoid that. Fixes: 5d38f32 ("um: drivers: Add virtio vhost-user driver") Signed-off-by: Johannes Berg <[email protected]> Acked-by: Anton Ivanov <[email protected]> Signed-off-by: Richard Weinberger <[email protected]>
1 parent 7e60746 commit bf9f80c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

arch/um/drivers/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ config UML_NET_SLIRP
337337
endmenu
338338

339339
config VIRTIO_UML
340-
tristate "UML driver for virtio devices"
340+
bool "UML driver for virtio devices"
341341
select VIRTIO
342342
help
343343
This driver provides support for virtio based paravirtual device

arch/um/drivers/virtio_uml.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
*
55
* Copyright(c) 2019 Intel Corporation
66
*
7-
* This module allows virtio devices to be used over a vhost-user socket.
7+
* This driver allows virtio devices to be used over a vhost-user socket.
88
*
99
* Guest devices can be instantiated by kernel module or command line
1010
* parameters. One device will be created for each parameter. Syntax:
1111
*
12-
* [virtio_uml.]device=<socket>:<virtio_id>[:<platform_id>]
12+
* virtio_uml.device=<socket>:<virtio_id>[:<platform_id>]
1313
* where:
1414
* <socket> := vhost-user socket path to connect
1515
* <virtio_id> := virtio device id (as in virtio_ids.h)

0 commit comments

Comments
 (0)