Skip to content

Commit bfcc1e6

Browse files
ffainellirafaeljw
authored andcommitted
PM: sleep: Do not assume that "mem" is always present
An implementation of suspend_ops is allowed to reject the PM_SUSPEND_MEM suspend type from its ->valid() callback, we should not assume that it is always present as this is not a correct reflection of what a firmware interface may support. Fixes: 406e793 ("PM / sleep: System sleep state selection interface rework") Signed-off-by: Florian Fainelli <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 6880fa6 commit bfcc1e6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/power/suspend.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,7 @@ static bool valid_state(suspend_state_t state)
171171

172172
void __init pm_states_init(void)
173173
{
174-
/* "mem" and "freeze" are always present in /sys/power/state. */
175-
pm_states[PM_SUSPEND_MEM] = pm_labels[PM_SUSPEND_MEM];
174+
/* "freeze" is always present in /sys/power/state. */
176175
pm_states[PM_SUSPEND_TO_IDLE] = pm_labels[PM_SUSPEND_TO_IDLE];
177176
/*
178177
* Suspend-to-idle should be supported even without any suspend_ops,
@@ -214,6 +213,7 @@ void suspend_set_ops(const struct platform_suspend_ops *ops)
214213
}
215214
if (valid_state(PM_SUSPEND_MEM)) {
216215
mem_sleep_states[PM_SUSPEND_MEM] = mem_sleep_labels[PM_SUSPEND_MEM];
216+
pm_states[PM_SUSPEND_MEM] = pm_labels[PM_SUSPEND_MEM];
217217
if (mem_sleep_default >= PM_SUSPEND_MEM)
218218
mem_sleep_current = PM_SUSPEND_MEM;
219219
}

0 commit comments

Comments
 (0)