Skip to content

Commit bfda610

Browse files
committed
s390/boot: Rename decompressor_printk() to boot_printk()
Rename decompressor_printk() to boot_printk() just to have a shorter function name, which also makes the code more readable. Reviewed-by: Sven Schnelle <[email protected]> Signed-off-by: Heiko Carstens <[email protected]>
1 parent fccb175 commit bfda610

File tree

4 files changed

+37
-41
lines changed

4 files changed

+37
-41
lines changed

arch/s390/boot/boot.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void print_pgm_check_info(void);
7070
unsigned long randomize_within_range(unsigned long size, unsigned long align,
7171
unsigned long min, unsigned long max);
7272
void setup_vmem(unsigned long kernel_start, unsigned long kernel_end, unsigned long asce_limit);
73-
void __printf(1, 2) decompressor_printk(const char *fmt, ...);
73+
void __printf(1, 2) boot_printk(const char *fmt, ...);
7474
void print_stacktrace(unsigned long sp);
7575
void error(char *m);
7676
int get_random(unsigned long limit, unsigned long *value);

arch/s390/boot/pgm_check_info.c

Lines changed: 23 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ static noinline char *strsym(void *ip)
8080
return buf;
8181
}
8282

83-
void decompressor_printk(const char *fmt, ...)
83+
void boot_printk(const char *fmt, ...)
8484
{
8585
char buf[1024] = { 0 };
8686
char *end = buf + sizeof(buf) - 1; /* make sure buf is 0 terminated */
@@ -129,13 +129,13 @@ void print_stacktrace(unsigned long sp)
129129
(unsigned long)_stack_end };
130130
bool first = true;
131131

132-
decompressor_printk("Call Trace:\n");
132+
boot_printk("Call Trace:\n");
133133
while (!(sp & 0x7) && on_stack(&boot_stack, sp, sizeof(struct stack_frame))) {
134134
struct stack_frame *sf = (struct stack_frame *)sp;
135135

136-
decompressor_printk(first ? "(sp:%016lx [<%016lx>] %pS)\n" :
137-
" sp:%016lx [<%016lx>] %pS\n",
138-
sp, sf->gprs[8], (void *)sf->gprs[8]);
136+
boot_printk(first ? "(sp:%016lx [<%016lx>] %pS)\n" :
137+
" sp:%016lx [<%016lx>] %pS\n",
138+
sp, sf->gprs[8], (void *)sf->gprs[8]);
139139
if (sf->back_chain <= sp)
140140
break;
141141
sp = sf->back_chain;
@@ -148,34 +148,30 @@ void print_pgm_check_info(void)
148148
unsigned long *gpregs = (unsigned long *)get_lowcore()->gpregs_save_area;
149149
struct psw_bits *psw = &psw_bits(get_lowcore()->psw_save_area);
150150

151-
decompressor_printk("Linux version %s\n", kernel_version);
151+
boot_printk("Linux version %s\n", kernel_version);
152152
if (!is_prot_virt_guest() && early_command_line[0])
153-
decompressor_printk("Kernel command line: %s\n", early_command_line);
154-
decompressor_printk("Kernel fault: interruption code %04x ilc:%x\n",
155-
get_lowcore()->pgm_code, get_lowcore()->pgm_ilc >> 1);
153+
boot_printk("Kernel command line: %s\n", early_command_line);
154+
boot_printk("Kernel fault: interruption code %04x ilc:%x\n",
155+
get_lowcore()->pgm_code, get_lowcore()->pgm_ilc >> 1);
156156
if (kaslr_enabled()) {
157-
decompressor_printk("Kernel random base: %lx\n", __kaslr_offset);
158-
decompressor_printk("Kernel random base phys: %lx\n", __kaslr_offset_phys);
157+
boot_printk("Kernel random base: %lx\n", __kaslr_offset);
158+
boot_printk("Kernel random base phys: %lx\n", __kaslr_offset_phys);
159159
}
160-
decompressor_printk("PSW : %016lx %016lx (%pS)\n",
161-
get_lowcore()->psw_save_area.mask,
162-
get_lowcore()->psw_save_area.addr,
163-
(void *)get_lowcore()->psw_save_area.addr);
164-
decompressor_printk(
160+
boot_printk("PSW : %016lx %016lx (%pS)\n",
161+
get_lowcore()->psw_save_area.mask,
162+
get_lowcore()->psw_save_area.addr,
163+
(void *)get_lowcore()->psw_save_area.addr);
164+
boot_printk(
165165
" R:%x T:%x IO:%x EX:%x Key:%x M:%x W:%x P:%x AS:%x CC:%x PM:%x RI:%x EA:%x\n",
166166
psw->per, psw->dat, psw->io, psw->ext, psw->key, psw->mcheck,
167167
psw->wait, psw->pstate, psw->as, psw->cc, psw->pm, psw->ri,
168168
psw->eaba);
169-
decompressor_printk("GPRS: %016lx %016lx %016lx %016lx\n",
170-
gpregs[0], gpregs[1], gpregs[2], gpregs[3]);
171-
decompressor_printk(" %016lx %016lx %016lx %016lx\n",
172-
gpregs[4], gpregs[5], gpregs[6], gpregs[7]);
173-
decompressor_printk(" %016lx %016lx %016lx %016lx\n",
174-
gpregs[8], gpregs[9], gpregs[10], gpregs[11]);
175-
decompressor_printk(" %016lx %016lx %016lx %016lx\n",
176-
gpregs[12], gpregs[13], gpregs[14], gpregs[15]);
169+
boot_printk("GPRS: %016lx %016lx %016lx %016lx\n", gpregs[0], gpregs[1], gpregs[2], gpregs[3]);
170+
boot_printk(" %016lx %016lx %016lx %016lx\n", gpregs[4], gpregs[5], gpregs[6], gpregs[7]);
171+
boot_printk(" %016lx %016lx %016lx %016lx\n", gpregs[8], gpregs[9], gpregs[10], gpregs[11]);
172+
boot_printk(" %016lx %016lx %016lx %016lx\n", gpregs[12], gpregs[13], gpregs[14], gpregs[15]);
177173
print_stacktrace(get_lowcore()->gpregs_save_area[15]);
178-
decompressor_printk("Last Breaking-Event-Address:\n");
179-
decompressor_printk(" [<%016lx>] %pS\n", (unsigned long)get_lowcore()->pgm_last_break,
180-
(void *)get_lowcore()->pgm_last_break);
174+
boot_printk("Last Breaking-Event-Address:\n");
175+
boot_printk(" [<%016lx>] %pS\n", (unsigned long)get_lowcore()->pgm_last_break,
176+
(void *)get_lowcore()->pgm_last_break);
181177
}

arch/s390/boot/physmem_info.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -190,25 +190,25 @@ static void die_oom(unsigned long size, unsigned long align, unsigned long min,
190190
enum reserved_range_type t;
191191
int i;
192192

193-
decompressor_printk("Linux version %s\n", kernel_version);
193+
boot_printk("Linux version %s\n", kernel_version);
194194
if (!is_prot_virt_guest() && early_command_line[0])
195-
decompressor_printk("Kernel command line: %s\n", early_command_line);
196-
decompressor_printk("Out of memory allocating %lx bytes %lx aligned in range %lx:%lx\n",
197-
size, align, min, max);
198-
decompressor_printk("Reserved memory ranges:\n");
195+
boot_printk("Kernel command line: %s\n", early_command_line);
196+
boot_printk("Out of memory allocating %lx bytes %lx aligned in range %lx:%lx\n",
197+
size, align, min, max);
198+
boot_printk("Reserved memory ranges:\n");
199199
for_each_physmem_reserved_range(t, range, &start, &end) {
200-
decompressor_printk("%016lx %016lx %s\n", start, end, get_rr_type_name(t));
200+
boot_printk("%016lx %016lx %s\n", start, end, get_rr_type_name(t));
201201
total_reserved_mem += end - start;
202202
}
203-
decompressor_printk("Usable online memory ranges (info source: %s [%x]):\n",
204-
get_physmem_info_source(), physmem_info.info_source);
203+
boot_printk("Usable online memory ranges (info source: %s [%x]):\n",
204+
get_physmem_info_source(), physmem_info.info_source);
205205
for_each_physmem_usable_range(i, &start, &end) {
206-
decompressor_printk("%016lx %016lx\n", start, end);
206+
boot_printk("%016lx %016lx\n", start, end);
207207
total_mem += end - start;
208208
}
209-
decompressor_printk("Usable online memory total: %lx Reserved: %lx Free: %lx\n",
210-
total_mem, total_reserved_mem,
211-
total_mem > total_reserved_mem ? total_mem - total_reserved_mem : 0);
209+
boot_printk("Usable online memory total: %lx Reserved: %lx Free: %lx\n",
210+
total_mem, total_reserved_mem,
211+
total_mem > total_reserved_mem ? total_mem - total_reserved_mem : 0);
212212
print_stacktrace(current_frame_address());
213213
sclp_early_printk("\n\n -- System halted\n");
214214
disabled_wait();

arch/s390/boot/startup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ static unsigned long setup_kernel_memory_layout(unsigned long kernel_size)
296296
kernel_start = round_down(kernel_end - kernel_size, THREAD_SIZE);
297297
} else if (vmax < __NO_KASLR_END_KERNEL || vsize > __NO_KASLR_END_KERNEL) {
298298
kernel_start = round_down(vmax - kernel_size, THREAD_SIZE);
299-
decompressor_printk("The kernel base address is forced to %lx\n", kernel_start);
299+
boot_printk("The kernel base address is forced to %lx\n", kernel_start);
300300
} else {
301301
kernel_start = __NO_KASLR_START_KERNEL;
302302
}

0 commit comments

Comments
 (0)