Skip to content

Commit c0260e2

Browse files
committed
reset: uniphier-glue: Use devm_reset_control_bulk_get_shared_deasserted()
Replace the pattern devm_reset_control_bulk_get_shared() / reset_control_bulk_deassert() / devm_add_action_or_reset() with devm_reset_control_bulk_get_shared_deasserted() for some reduction in boilerplate. Acked-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Philipp Zabel <[email protected]>
1 parent d872bed commit c0260e2

File tree

1 file changed

+5
-19
lines changed

1 file changed

+5
-19
lines changed

drivers/reset/reset-uniphier-glue.c

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,6 @@ static void uniphier_clk_disable(void *_priv)
3535
clk_bulk_disable_unprepare(priv->data->nclks, priv->clk);
3636
}
3737

38-
static void uniphier_rst_assert(void *_priv)
39-
{
40-
struct uniphier_glue_reset_priv *priv = _priv;
41-
42-
reset_control_bulk_assert(priv->data->nrsts, priv->rst);
43-
}
44-
4538
static int uniphier_glue_reset_probe(struct platform_device *pdev)
4639
{
4740
struct device *dev = &pdev->dev;
@@ -68,13 +61,6 @@ static int uniphier_glue_reset_probe(struct platform_device *pdev)
6861
if (ret)
6962
return ret;
7063

71-
for (i = 0; i < priv->data->nrsts; i++)
72-
priv->rst[i].id = priv->data->reset_names[i];
73-
ret = devm_reset_control_bulk_get_shared(dev, priv->data->nrsts,
74-
priv->rst);
75-
if (ret)
76-
return ret;
77-
7864
ret = clk_bulk_prepare_enable(priv->data->nclks, priv->clk);
7965
if (ret)
8066
return ret;
@@ -83,11 +69,11 @@ static int uniphier_glue_reset_probe(struct platform_device *pdev)
8369
if (ret)
8470
return ret;
8571

86-
ret = reset_control_bulk_deassert(priv->data->nrsts, priv->rst);
87-
if (ret)
88-
return ret;
89-
90-
ret = devm_add_action_or_reset(dev, uniphier_rst_assert, priv);
72+
for (i = 0; i < priv->data->nrsts; i++)
73+
priv->rst[i].id = priv->data->reset_names[i];
74+
ret = devm_reset_control_bulk_get_shared_deasserted(dev,
75+
priv->data->nrsts,
76+
priv->rst);
9177
if (ret)
9278
return ret;
9379

0 commit comments

Comments
 (0)