Skip to content

Commit c031d3d

Browse files
crojewsk-intelbroonie
authored andcommitted
ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components
Recent series of patches targeting broadwell boards, while enabling SOF, changed behavior for non-SOF solutions. In essence replacing platform 'dummy' with actual 'platform' causes redundant stream initialization to occur during audio start. hw_params for haswell-pcm destroys initial stream right after its creation - only to recreate it again from proceed from there. While harmless so far, this flow isn't right and should be corrected. The actual need for dummy components for SSP0 link is questionable but that issue is subject for another series. Fixes: 4865bde ("ASoC: Intel: bdw-rt5677: change cpu_dai and platform components for SOF") Signed-off-by: Cezary Rojewski <[email protected]> Acked-by: Pierre-Louis Bossart <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 68999d9 commit c031d3d

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

sound/soc/intel/boards/bdw-rt5677.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,6 @@ SND_SOC_DAILINK_DEF(be,
298298
#if IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
299299
SND_SOC_DAILINK_DEF(ssp0_port,
300300
DAILINK_COMP_ARRAY(COMP_CPU("ssp0-port")));
301-
#else
302-
SND_SOC_DAILINK_DEF(ssp0_port,
303-
DAILINK_COMP_ARRAY(COMP_DUMMY()));
304301
#endif
305302

306303
/* Wake on voice interface */
@@ -350,7 +347,11 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = {
350347
.dpcm_playback = 1,
351348
.dpcm_capture = 1,
352349
.init = bdw_rt5677_init,
350+
#if !IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)
351+
SND_SOC_DAILINK_REG(dummy, be, dummy),
352+
#else
353353
SND_SOC_DAILINK_REG(ssp0_port, be, platform),
354+
#endif
354355
},
355356
};
356357

0 commit comments

Comments
 (0)