Skip to content

Commit c0403e4

Browse files
ashutoshxlucasdemarchi
authored andcommitted
drm/xe/oa: Fix "Missing outer runtime PM protection" warning
Fix the following drm_WARN: [953.586396] xe 0000:00:02.0: [drm] Missing outer runtime PM protection ... <4> [953.587090] ? xe_pm_runtime_get_noresume+0x8d/0xa0 [xe] <4> [953.587208] guc_exec_queue_add_msg+0x28/0x130 [xe] <4> [953.587319] guc_exec_queue_fini+0x3a/0x40 [xe] <4> [953.587425] xe_exec_queue_destroy+0xb3/0xf0 [xe] <4> [953.587515] xe_oa_release+0x9c/0xc0 [xe] Suggested-by: John Harrison <[email protected]> Suggested-by: Matthew Brost <[email protected]> Fixes: e936f88 ("drm/xe/oa/uapi: Expose OA stream fd") Cc: [email protected] Signed-off-by: Ashutosh Dixit <[email protected]> Reviewed-by: Matthew Brost <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit b107c63) Signed-off-by: Lucas De Marchi <[email protected]>
1 parent be7eeab commit c0403e4

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/gpu/drm/xe/xe_oa.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1206,9 +1206,11 @@ static int xe_oa_release(struct inode *inode, struct file *file)
12061206
struct xe_oa_stream *stream = file->private_data;
12071207
struct xe_gt *gt = stream->gt;
12081208

1209+
xe_pm_runtime_get(gt_to_xe(gt));
12091210
mutex_lock(&gt->oa.gt_lock);
12101211
xe_oa_destroy_locked(stream);
12111212
mutex_unlock(&gt->oa.gt_lock);
1213+
xe_pm_runtime_put(gt_to_xe(gt));
12121214

12131215
/* Release the reference the OA stream kept on the driver */
12141216
drm_dev_put(&gt_to_xe(gt)->drm);

0 commit comments

Comments
 (0)