Skip to content

Commit c064de8

Browse files
linmag7martinkpetersen
authored andcommitted
scsi: qla1280: Fix hw revision numbering for ISP1020/1040
Fix the hardware revision numbering for Qlogic ISP1020/1040 boards. HWMASK suggests that the revision number only needs four bits, this is consistent with how NetBSD does things in their ISP driver. Verified on a IPS1040B which is seen as rev 5 not as BIT_4. Signed-off-by: Magnus Lindholm <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 8e3b634 commit c064de8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/scsi/qla1280.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,12 @@ struct device_reg {
116116
uint16_t id_h; /* ID high */
117117
uint16_t cfg_0; /* Configuration 0 */
118118
#define ISP_CFG0_HWMSK 0x000f /* Hardware revision mask */
119-
#define ISP_CFG0_1020 BIT_0 /* ISP1020 */
120-
#define ISP_CFG0_1020A BIT_1 /* ISP1020A */
121-
#define ISP_CFG0_1040 BIT_2 /* ISP1040 */
122-
#define ISP_CFG0_1040A BIT_3 /* ISP1040A */
123-
#define ISP_CFG0_1040B BIT_4 /* ISP1040B */
124-
#define ISP_CFG0_1040C BIT_5 /* ISP1040C */
119+
#define ISP_CFG0_1020 1 /* ISP1020 */
120+
#define ISP_CFG0_1020A 2 /* ISP1020A */
121+
#define ISP_CFG0_1040 3 /* ISP1040 */
122+
#define ISP_CFG0_1040A 4 /* ISP1040A */
123+
#define ISP_CFG0_1040B 5 /* ISP1040B */
124+
#define ISP_CFG0_1040C 6 /* ISP1040C */
125125
uint16_t cfg_1; /* Configuration 1 */
126126
#define ISP_CFG1_F128 BIT_6 /* 128-byte FIFO threshold */
127127
#define ISP_CFG1_F64 BIT_4|BIT_5 /* 128-byte FIFO threshold */

0 commit comments

Comments
 (0)