Skip to content

Commit c0735ae

Browse files
geertuRich Felker
authored andcommitted
sh: stacktrace: Remove stacktrace_ops.stack()
The SH implementation never called stacktrace_ops.stack(). Presumably this was copied from the x86 implementation. Hence remove the method, and all implementations (most of them are dummies). Signed-off-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Rich Felker <[email protected]>
1 parent eac1a48 commit c0735ae

File tree

5 files changed

+0
-29
lines changed

5 files changed

+0
-29
lines changed

arch/sh/include/asm/stacktrace.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212

1313
struct stacktrace_ops {
1414
void (*address)(void *data, unsigned long address, int reliable);
15-
/* On negative return stop dumping */
16-
int (*stack)(void *data, char *name);
1715
};
1816

1917
void dump_trace(struct task_struct *tsk, struct pt_regs *regs,

arch/sh/kernel/dumpstack.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,6 @@ stack_reader_dump(struct task_struct *task, struct pt_regs *regs,
107107
}
108108
}
109109

110-
static int print_trace_stack(void *data, char *name)
111-
{
112-
printk("%s <%s> ", (char *)data, name);
113-
return 0;
114-
}
115-
116110
/*
117111
* Print one address/symbol entries per line.
118112
*/
@@ -123,7 +117,6 @@ static void print_trace_address(void *data, unsigned long addr, int reliable)
123117
}
124118

125119
static const struct stacktrace_ops print_trace_ops = {
126-
.stack = print_trace_stack,
127120
.address = print_trace_address,
128121
};
129122

arch/sh/kernel/perf_callchain.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,6 @@
1111
#include <asm/unwinder.h>
1212
#include <asm/ptrace.h>
1313

14-
static int callchain_stack(void *data, char *name)
15-
{
16-
return 0;
17-
}
18-
1914
static void callchain_address(void *data, unsigned long addr, int reliable)
2015
{
2116
struct perf_callchain_entry_ctx *entry = data;
@@ -25,7 +20,6 @@ static void callchain_address(void *data, unsigned long addr, int reliable)
2520
}
2621

2722
static const struct stacktrace_ops callchain_ops = {
28-
.stack = callchain_stack,
2923
.address = callchain_address,
3024
};
3125

arch/sh/kernel/stacktrace.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
#include <asm/ptrace.h>
1616
#include <asm/stacktrace.h>
1717

18-
static int save_stack_stack(void *data, char *name)
19-
{
20-
return 0;
21-
}
22-
2318
/*
2419
* Save stack-backtrace addresses into a stack_trace buffer.
2520
*/
@@ -40,7 +35,6 @@ static void save_stack_address(void *data, unsigned long addr, int reliable)
4035
}
4136

4237
static const struct stacktrace_ops save_stack_ops = {
43-
.stack = save_stack_stack,
4438
.address = save_stack_address,
4539
};
4640

@@ -73,7 +67,6 @@ save_stack_address_nosched(void *data, unsigned long addr, int reliable)
7367
}
7468

7569
static const struct stacktrace_ops save_stack_ops_nosched = {
76-
.stack = save_stack_stack,
7770
.address = save_stack_address_nosched,
7871
};
7972

arch/sh/oprofile/backtrace.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,6 @@
1919
#include <asm/sections.h>
2020
#include <asm/stacktrace.h>
2121

22-
static int backtrace_stack(void *data, char *name)
23-
{
24-
/* Yes, we want all stacks */
25-
return 0;
26-
}
27-
2822
static void backtrace_address(void *data, unsigned long addr, int reliable)
2923
{
3024
unsigned int *depth = data;
@@ -34,7 +28,6 @@ static void backtrace_address(void *data, unsigned long addr, int reliable)
3428
}
3529

3630
static struct stacktrace_ops backtrace_ops = {
37-
.stack = backtrace_stack,
3831
.address = backtrace_address,
3932
};
4033

0 commit comments

Comments
 (0)