Skip to content

Commit c0b0675

Browse files
committed
Revert "perf report: Append inlines to non-DWARF callchains"
This reverts commit 46d21ec. The tests were made with a specific workload, further tests on a recently updated fedora 38 system with a system wide perf.data file shows 'perf report' taking excessive time resolving inlines in vmlinux, so lets revert this until a full investigation and improvement on the addr2line support code is made. Reported-by: Jesper Dangaard Brouer <[email protected]> Acked-by: Artem Savkov <[email protected]> Tested-by: Jesper Dangaard Brouer <[email protected]> Cc: Andrii Nakryiko <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Adrian Hunter <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Ian Rogers <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Masami Hiramatsu <[email protected]> Cc: Milian Wolff <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
1 parent 52a93d3 commit c0b0675

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

tools/perf/util/machine.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545

4646
static void __machine__remove_thread(struct machine *machine, struct thread_rb_node *nd,
4747
struct thread *th, bool lock);
48-
static int append_inlines(struct callchain_cursor *cursor, struct map_symbol *ms, u64 ip);
4948

5049
static struct dso *machine__kernel_dso(struct machine *machine)
5150
{
@@ -2385,10 +2384,6 @@ static int add_callchain_ip(struct thread *thread,
23852384
ms.maps = maps__get(al.maps);
23862385
ms.map = map__get(al.map);
23872386
ms.sym = al.sym;
2388-
2389-
if (!branch && append_inlines(cursor, &ms, ip) == 0)
2390-
goto out;
2391-
23922387
srcline = callchain_srcline(&ms, al.addr);
23932388
err = callchain_cursor_append(cursor, ip, &ms,
23942389
branch, flags, nr_loop_iter,

0 commit comments

Comments
 (0)