Skip to content

Commit c0eca14

Browse files
committed
dt-bindings: phy: qcom: Fix missing 'ranges' and example addresses
The QCom QMP PHY bindings have child nodes with translatable (MMIO) addresses, so a 'ranges' property is required in the parent node. Additionally, the examples default to 1 address and size cell, so let's fix that, too. Fixes: ccf51c1 ("dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml") Cc: Andy Gross <[email protected]> Cc: Bjorn Andersson <[email protected]> Cc: Kishon Vijay Abraham I <[email protected]> Cc: Vinod Koul <[email protected]> Cc: Manu Gautam <[email protected]> Cc: [email protected] Signed-off-by: Rob Herring <[email protected]>
1 parent 086e907 commit c0eca14

File tree

2 files changed

+33
-25
lines changed

2 files changed

+33
-25
lines changed

Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ properties:
4444
"#size-cells":
4545
enum: [ 1, 2 ]
4646

47+
ranges: true
48+
4749
clocks:
4850
minItems: 1
4951
maxItems: 4
@@ -87,6 +89,7 @@ required:
8789
- "#clock-cells"
8890
- "#address-cells"
8991
- "#size-cells"
92+
- ranges
9093
- clocks
9194
- clock-names
9295
- resets
@@ -281,10 +284,11 @@ examples:
281284
#include <dt-bindings/clock/qcom,gcc-sdm845.h>
282285
usb_2_qmpphy: phy-wrapper@88eb000 {
283286
compatible = "qcom,sdm845-qmp-usb3-uni-phy";
284-
reg = <0 0x088eb000 0 0x18c>;
287+
reg = <0x088eb000 0x18c>;
285288
#clock-cells = <1>;
286-
#address-cells = <2>;
287-
#size-cells = <2>;
289+
#address-cells = <1>;
290+
#size-cells = <1>;
291+
ranges = <0x0 0x088eb000 0x2000>;
288292
289293
clocks = <&gcc GCC_USB3_SEC_PHY_AUX_CLK >,
290294
<&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>,
@@ -299,11 +303,11 @@ examples:
299303
vdda-phy-supply = <&vdda_usb2_ss_1p2>;
300304
vdda-pll-supply = <&vdda_usb2_ss_core>;
301305
302-
usb_2_ssphy: phy@88eb200 {
303-
reg = <0 0x088eb200 0 0x128>,
304-
<0 0x088eb400 0 0x1fc>,
305-
<0 0x088eb800 0 0x218>,
306-
<0 0x088eb600 0 0x70>;
306+
usb_2_ssphy: phy@200 {
307+
reg = <0x200 0x128>,
308+
<0x400 0x1fc>,
309+
<0x800 0x218>,
310+
<0x600 0x70>;
307311
#clock-cells = <0>;
308312
#phy-cells = <0>;
309313
clocks = <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>;

Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ properties:
3434
"#size-cells":
3535
enum: [ 1, 2 ]
3636

37+
ranges: true
38+
3739
clocks:
3840
items:
3941
- description: Phy aux clock.
@@ -86,6 +88,7 @@ required:
8688
- "#clock-cells"
8789
- "#address-cells"
8890
- "#size-cells"
91+
- ranges
8992
- clocks
9093
- clock-names
9194
- resets
@@ -100,12 +103,13 @@ examples:
100103
#include <dt-bindings/clock/qcom,gcc-sdm845.h>
101104
usb_1_qmpphy: phy-wrapper@88e9000 {
102105
compatible = "qcom,sdm845-qmp-usb3-phy";
103-
reg = <0 0x088e9000 0 0x18c>,
104-
<0 0x088e8000 0 0x10>;
106+
reg = <0x088e9000 0x18c>,
107+
<0x088e8000 0x10>;
105108
reg-names = "reg-base", "dp_com";
106109
#clock-cells = <1>;
107-
#address-cells = <2>;
108-
#size-cells = <2>;
110+
#address-cells = <1>;
111+
#size-cells = <1>;
112+
ranges = <0x0 0x088e9000 0x1000>;
109113
110114
clocks = <&gcc GCC_USB3_PRIM_PHY_AUX_CLK>,
111115
<&gcc GCC_USB_PHY_CFG_AHB2PHY_CLK>,
@@ -120,17 +124,17 @@ examples:
120124
vdda-phy-supply = <&vdda_usb2_ss_1p2>;
121125
vdda-pll-supply = <&vdda_usb2_ss_core>;
122126
123-
usb_1_ssphy: phy@88e9200 {
124-
reg = <0 0x088e9200 0 0x128>,
125-
<0 0x088e9400 0 0x200>,
126-
<0 0x088e9c00 0 0x218>,
127-
<0 0x088e9600 0 0x128>,
128-
<0 0x088e9800 0 0x200>,
129-
<0 0x088e9a00 0 0x100>;
130-
#clock-cells = <0>;
131-
#phy-cells = <0>;
132-
clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
133-
clock-names = "pipe0";
134-
clock-output-names = "usb3_phy_pipe_clk_src";
135-
};
127+
phy@200 {
128+
reg = <0x200 0x128>,
129+
<0x400 0x200>,
130+
<0xc00 0x218>,
131+
<0x600 0x128>,
132+
<0x800 0x200>,
133+
<0xa00 0x100>;
134+
#clock-cells = <0>;
135+
#phy-cells = <0>;
136+
clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>;
137+
clock-names = "pipe0";
138+
clock-output-names = "usb3_phy_pipe_clk_src";
136139
};
140+
};

0 commit comments

Comments
 (0)