Skip to content

Commit c0f866d

Browse files
jmaneyrol-invnjic23
authored andcommitted
iio: imu: inv_icm42600: fix spi burst write not supported
Burst write with SPI is not working for all icm42600 chips. It was only used for setting user offsets with regmap_bulk_write. Add specific SPI regmap config for using only single write with SPI. Fixes: 9f9ff91 ("iio: imu: inv_icm42600: add SPI driver for inv_icm42600 driver") Cc: [email protected] Signed-off-by: Jean-Baptiste Maneyrol <[email protected]> Link: https://patch.msgid.link/20241112-inv-icm42600-fix-spi-burst-write-not-supported-v2-1-97690dc03607@tdk.com Signed-off-by: Jonathan Cameron <[email protected]>
1 parent fa13ac6 commit c0f866d

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

drivers/iio/imu/inv_icm42600/inv_icm42600.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,7 @@ struct inv_icm42600_sensor_state {
403403
typedef int (*inv_icm42600_bus_setup)(struct inv_icm42600_state *);
404404

405405
extern const struct regmap_config inv_icm42600_regmap_config;
406+
extern const struct regmap_config inv_icm42600_spi_regmap_config;
406407
extern const struct dev_pm_ops inv_icm42600_pm_ops;
407408

408409
const struct iio_mount_matrix *

drivers/iio/imu/inv_icm42600/inv_icm42600_core.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,21 @@ const struct regmap_config inv_icm42600_regmap_config = {
8787
};
8888
EXPORT_SYMBOL_NS_GPL(inv_icm42600_regmap_config, "IIO_ICM42600");
8989

90+
/* define specific regmap for SPI not supporting burst write */
91+
const struct regmap_config inv_icm42600_spi_regmap_config = {
92+
.name = "inv_icm42600",
93+
.reg_bits = 8,
94+
.val_bits = 8,
95+
.max_register = 0x4FFF,
96+
.ranges = inv_icm42600_regmap_ranges,
97+
.num_ranges = ARRAY_SIZE(inv_icm42600_regmap_ranges),
98+
.volatile_table = inv_icm42600_regmap_volatile_accesses,
99+
.rd_noinc_table = inv_icm42600_regmap_rd_noinc_accesses,
100+
.cache_type = REGCACHE_RBTREE,
101+
.use_single_write = true,
102+
};
103+
EXPORT_SYMBOL_NS_GPL(inv_icm42600_spi_regmap_config, "IIO_ICM42600");
104+
90105
struct inv_icm42600_hw {
91106
uint8_t whoami;
92107
const char *name;

drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ static int inv_icm42600_probe(struct spi_device *spi)
5959
return -EINVAL;
6060
chip = (uintptr_t)match;
6161

62-
regmap = devm_regmap_init_spi(spi, &inv_icm42600_regmap_config);
62+
/* use SPI specific regmap */
63+
regmap = devm_regmap_init_spi(spi, &inv_icm42600_spi_regmap_config);
6364
if (IS_ERR(regmap))
6465
return PTR_ERR(regmap);
6566

0 commit comments

Comments
 (0)