Skip to content

Commit c10cd03

Browse files
billy-tsailinusw
authored andcommitted
pinctrl: pinctrl-aspeed-g6: Fix register offset for pinconf of GPIOR-T
The register offset to disable the internal pull-down of GPIOR~T is 0x630 instead of 0x620, as specified in the Ast2600 datasheet v15 The datasheet can download from the official Aspeed website. Fixes: 15711ba ("pinctrl: aspeed-g6: Add AST2600 pinconf support") Reported-by: Delphine CC Chiu <[email protected]> Signed-off-by: Billy Tsai <[email protected]> Reviewed-by: Paul Menzel <[email protected]> Reviewed-by: Andrew Jeffery <[email protected]> Message-ID: <[email protected]> Signed-off-by: Linus Walleij <[email protected]>
1 parent 4cece76 commit c10cd03

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
#define SCU614 0x614 /* Disable GPIO Internal Pull-Down #1 */
4444
#define SCU618 0x618 /* Disable GPIO Internal Pull-Down #2 */
4545
#define SCU61C 0x61c /* Disable GPIO Internal Pull-Down #3 */
46-
#define SCU620 0x620 /* Disable GPIO Internal Pull-Down #4 */
46+
#define SCU630 0x630 /* Disable GPIO Internal Pull-Down #4 */
4747
#define SCU634 0x634 /* Disable GPIO Internal Pull-Down #5 */
4848
#define SCU638 0x638 /* Disable GPIO Internal Pull-Down #6 */
4949
#define SCU690 0x690 /* Multi-function Pin Control #24 */
@@ -2495,38 +2495,38 @@ static struct aspeed_pin_config aspeed_g6_configs[] = {
24952495
ASPEED_PULL_DOWN_PINCONF(D14, SCU61C, 0),
24962496

24972497
/* GPIOS7 */
2498-
ASPEED_PULL_DOWN_PINCONF(T24, SCU620, 23),
2498+
ASPEED_PULL_DOWN_PINCONF(T24, SCU630, 23),
24992499
/* GPIOS6 */
2500-
ASPEED_PULL_DOWN_PINCONF(P23, SCU620, 22),
2500+
ASPEED_PULL_DOWN_PINCONF(P23, SCU630, 22),
25012501
/* GPIOS5 */
2502-
ASPEED_PULL_DOWN_PINCONF(P24, SCU620, 21),
2502+
ASPEED_PULL_DOWN_PINCONF(P24, SCU630, 21),
25032503
/* GPIOS4 */
2504-
ASPEED_PULL_DOWN_PINCONF(R26, SCU620, 20),
2504+
ASPEED_PULL_DOWN_PINCONF(R26, SCU630, 20),
25052505
/* GPIOS3*/
2506-
ASPEED_PULL_DOWN_PINCONF(R24, SCU620, 19),
2506+
ASPEED_PULL_DOWN_PINCONF(R24, SCU630, 19),
25072507
/* GPIOS2 */
2508-
ASPEED_PULL_DOWN_PINCONF(T26, SCU620, 18),
2508+
ASPEED_PULL_DOWN_PINCONF(T26, SCU630, 18),
25092509
/* GPIOS1 */
2510-
ASPEED_PULL_DOWN_PINCONF(T25, SCU620, 17),
2510+
ASPEED_PULL_DOWN_PINCONF(T25, SCU630, 17),
25112511
/* GPIOS0 */
2512-
ASPEED_PULL_DOWN_PINCONF(R23, SCU620, 16),
2512+
ASPEED_PULL_DOWN_PINCONF(R23, SCU630, 16),
25132513

25142514
/* GPIOR7 */
2515-
ASPEED_PULL_DOWN_PINCONF(U26, SCU620, 15),
2515+
ASPEED_PULL_DOWN_PINCONF(U26, SCU630, 15),
25162516
/* GPIOR6 */
2517-
ASPEED_PULL_DOWN_PINCONF(W26, SCU620, 14),
2517+
ASPEED_PULL_DOWN_PINCONF(W26, SCU630, 14),
25182518
/* GPIOR5 */
2519-
ASPEED_PULL_DOWN_PINCONF(T23, SCU620, 13),
2519+
ASPEED_PULL_DOWN_PINCONF(T23, SCU630, 13),
25202520
/* GPIOR4 */
2521-
ASPEED_PULL_DOWN_PINCONF(U25, SCU620, 12),
2521+
ASPEED_PULL_DOWN_PINCONF(U25, SCU630, 12),
25222522
/* GPIOR3*/
2523-
ASPEED_PULL_DOWN_PINCONF(V26, SCU620, 11),
2523+
ASPEED_PULL_DOWN_PINCONF(V26, SCU630, 11),
25242524
/* GPIOR2 */
2525-
ASPEED_PULL_DOWN_PINCONF(V24, SCU620, 10),
2525+
ASPEED_PULL_DOWN_PINCONF(V24, SCU630, 10),
25262526
/* GPIOR1 */
2527-
ASPEED_PULL_DOWN_PINCONF(U24, SCU620, 9),
2527+
ASPEED_PULL_DOWN_PINCONF(U24, SCU630, 9),
25282528
/* GPIOR0 */
2529-
ASPEED_PULL_DOWN_PINCONF(V25, SCU620, 8),
2529+
ASPEED_PULL_DOWN_PINCONF(V25, SCU630, 8),
25302530

25312531
/* GPIOX7 */
25322532
ASPEED_PULL_DOWN_PINCONF(AB10, SCU634, 31),

0 commit comments

Comments
 (0)