Skip to content

Commit c115169

Browse files
committed
drm/xe/reg_sr: Stop setting all whitelist slots
Currently xe_reg_sr_apply_whitelist() sets the unused values to a known used value for no good reason: it could just leave it with the HW default. The behavior is slightly different if there are no whitelist registers for the engine as the function returns early. This is not needed, so just drop the addition writes for the unused slots. Later this will allow to reduce the amount of registers passed to GuC for save/restore. Reviewed-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Lucas De Marchi <[email protected]>
1 parent bd02219 commit c115169

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/gpu/drm/xe/xe_reg_sr.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -227,13 +227,6 @@ void xe_reg_sr_apply_whitelist(struct xe_hw_engine *hwe)
227227
slot++;
228228
}
229229

230-
/* And clear the rest just in case of garbage */
231-
for (; slot < RING_MAX_NONPRIV_SLOTS; slot++) {
232-
u32 addr = RING_NOPID(mmio_base).addr;
233-
234-
xe_mmio_write32(&gt->mmio, RING_FORCE_TO_NONPRIV(mmio_base, slot), addr);
235-
}
236-
237230
xe_force_wake_put(gt_to_fw(gt), fw_ref);
238231

239232
return;

0 commit comments

Comments
 (0)