Skip to content

Commit c132fe7

Browse files
Yuuoniyvinodkoul
authored andcommitted
dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not needed anymore. Add missing of_node_put() in to fix this. Fixes: ec9bfa1 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr") Signed-off-by: Miaoqian Lin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent f2906aa commit c132fe7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/dma/ti/dma-crossbar.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
268268
mutex_unlock(&xbar->mutex);
269269
dev_err(&pdev->dev, "Run out of free DMA requests\n");
270270
kfree(map);
271+
of_node_put(dma_spec->np);
271272
return ERR_PTR(-ENOMEM);
272273
}
273274
set_bit(map->xbar_out, xbar->dma_inuse);

0 commit comments

Comments
 (0)