Skip to content

Commit c15b814

Browse files
Matthew Wilcox (Oracle)brauner
authored andcommitted
ecryptfs: Convert ecryptfs_decrypt_page() to take a folio
Both callers have a folio, so pass it in and use it throughout. Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Christian Brauner <[email protected]>
1 parent 6b9c0e8 commit c15b814

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

fs/ecryptfs/crypto.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ int ecryptfs_encrypt_page(struct folio *folio)
461461

462462
/**
463463
* ecryptfs_decrypt_page
464-
* @page: Page mapped from the eCryptfs inode for the file; data read
464+
* @folio: Folio mapped from the eCryptfs inode for the file; data read
465465
* and decrypted from the lower file will be written into this
466466
* page
467467
*
@@ -475,7 +475,7 @@ int ecryptfs_encrypt_page(struct folio *folio)
475475
*
476476
* Returns zero on success; negative on error
477477
*/
478-
int ecryptfs_decrypt_page(struct page *page)
478+
int ecryptfs_decrypt_page(struct folio *folio)
479479
{
480480
struct inode *ecryptfs_inode;
481481
struct ecryptfs_crypt_stat *crypt_stat;
@@ -484,13 +484,13 @@ int ecryptfs_decrypt_page(struct page *page)
484484
loff_t lower_offset;
485485
int rc = 0;
486486

487-
ecryptfs_inode = page->mapping->host;
487+
ecryptfs_inode = folio->mapping->host;
488488
crypt_stat =
489489
&(ecryptfs_inode_to_private(ecryptfs_inode)->crypt_stat);
490490
BUG_ON(!(crypt_stat->flags & ECRYPTFS_ENCRYPTED));
491491

492-
lower_offset = lower_offset_for_page(crypt_stat, page);
493-
page_virt = kmap_local_page(page);
492+
lower_offset = lower_offset_for_page(crypt_stat, &folio->page);
493+
page_virt = kmap_local_folio(folio, 0);
494494
rc = ecryptfs_read_lower(page_virt, lower_offset, PAGE_SIZE,
495495
ecryptfs_inode);
496496
kunmap_local(page_virt);
@@ -504,6 +504,7 @@ int ecryptfs_decrypt_page(struct page *page)
504504
for (extent_offset = 0;
505505
extent_offset < (PAGE_SIZE / crypt_stat->extent_size);
506506
extent_offset++) {
507+
struct page *page = folio_page(folio, 0);
507508
rc = crypt_extent(crypt_stat, page, page,
508509
extent_offset, DECRYPT);
509510
if (rc) {

fs/ecryptfs/ecryptfs_kernel.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ void ecryptfs_destroy_mount_crypt_stat(
570570
int ecryptfs_init_crypt_ctx(struct ecryptfs_crypt_stat *crypt_stat);
571571
int ecryptfs_write_inode_size_to_metadata(struct inode *ecryptfs_inode);
572572
int ecryptfs_encrypt_page(struct folio *folio);
573-
int ecryptfs_decrypt_page(struct page *page);
573+
int ecryptfs_decrypt_page(struct folio *folio);
574574
int ecryptfs_write_metadata(struct dentry *ecryptfs_dentry,
575575
struct inode *ecryptfs_inode);
576576
int ecryptfs_read_metadata(struct dentry *ecryptfs_dentry);

fs/ecryptfs/mmap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ static int ecryptfs_read_folio(struct file *file, struct folio *folio)
194194
}
195195
}
196196
} else {
197-
err = ecryptfs_decrypt_page(&folio->page);
197+
err = ecryptfs_decrypt_page(folio);
198198
if (err) {
199199
ecryptfs_printk(KERN_ERR, "Error decrypting page; "
200200
"err = [%d]\n", err);
@@ -305,7 +305,7 @@ static int ecryptfs_write_begin(struct file *file,
305305
folio_zero_range(folio, 0, PAGE_SIZE);
306306
folio_mark_uptodate(folio);
307307
} else if (len < PAGE_SIZE) {
308-
rc = ecryptfs_decrypt_page(&folio->page);
308+
rc = ecryptfs_decrypt_page(folio);
309309
if (rc) {
310310
printk(KERN_ERR "%s: Error decrypting "
311311
"page at index [%ld]; "

0 commit comments

Comments
 (0)