Skip to content

Commit c1822fb

Browse files
Dheeraj Reddy Jonnalagaddakuba-moo
authored andcommitted
wireguard: allowedips: remove redundant selftest call
This commit fixes a useless call issue detected by Coverity (CID 1508092). The call to horrible_allowedips_lookup_v4 is unnecessary as its return value is never checked. Signed-off-by: Dheeraj Reddy Jonnalagadda <[email protected]> Fixes: e7096c1 ("net: WireGuard secure network tunnel") Signed-off-by: Jason A. Donenfeld <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 2c86291 commit c1822fb

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/wireguard/selftest/allowedips.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,6 @@ static __init bool randomized_test(void)
383383
for (i = 0; i < NUM_QUERIES; ++i) {
384384
get_random_bytes(ip, 4);
385385
if (lookup(t.root4, 32, ip) != horrible_allowedips_lookup_v4(&h, (struct in_addr *)ip)) {
386-
horrible_allowedips_lookup_v4(&h, (struct in_addr *)ip);
387386
pr_err("allowedips random v4 self-test: FAIL\n");
388387
goto free;
389388
}

0 commit comments

Comments
 (0)