Skip to content

Commit c21a743

Browse files
miquelraynaltmlind
authored andcommitted
ARM: dts: am33xx-l4: Add missing touchscreen clock properties
When adding support for TI magadc (Magnetic Stripe Reader and ADC), the MFD driver common to the touchscreen and the ADC got updated to ease the insertion of a new DT node for the ADC, with its own compatible, clocks, etc. Commit 235a96e ("mfd: ti_am335x_tscadc: Don't search the tree for our clock") removed one compatible specific information which was the clock name, because the clock was looked up from scratch in the DT while this hardware block was only fed by a single clock, already defined and properly filled in the DT. Problem is, this change was only validated with an am437x-based board, where the clocks are effectively correctly defined and referenced. But on am33xx, the ADC clock is also correctly defined but is not referenced with a clock phandle as it ought to be. The touchscreen bindings clearly state that the clocks/clock-names properties are mandatory, but they have been forgotten in one DTSI. This was probably not noticed in the first place because of the clock actually existing and the clk_get() call going through all the tree anyway. Add the missing clock phandles in the am33xx touchscreen description. Reported-by: H. Nikolaus Schaller <[email protected]> Fixes: 235a96e ("mfd: ti_am335x_tscadc: Don't search the tree for our clock") Signed-off-by: Miquel Raynal <[email protected]> Tested-by: H. Nikolaus Schaller <[email protected]> Message-Id: <[email protected]> Signed-off-by: Tony Lindgren <[email protected]>
1 parent 09269dd commit c21a743

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

arch/arm/boot/dts/am33xx-l4.dtsi

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,8 @@
263263
compatible = "ti,am3359-tscadc";
264264
reg = <0x0 0x1000>;
265265
interrupts = <16>;
266+
clocks = <&adc_tsc_fck>;
267+
clock-names = "fck";
266268
status = "disabled";
267269
dmas = <&edma 53 0>, <&edma 57 0>;
268270
dma-names = "fifo0", "fifo1";

0 commit comments

Comments
 (0)