Skip to content

Commit c229d57

Browse files
urezkiFrederic Weisbecker
authored andcommitted
rcuscale: Remove redundant WARN_ON_ONCE() splat
There are two places where WARN_ON_ONCE() is called two times in the error paths. One which is encapsulated into if() condition and another one, which is unnecessary, is placed in the brackets. Remove an extra WARN_ON_ONCE() splat which is in brackets. Reviewed-by: Paul E. McKenney <[email protected]> Reviewed-by: Neeraj Upadhyay <[email protected]> Signed-off-by: Uladzislau Rezki (Sony) <[email protected]> Signed-off-by: Frederic Weisbecker <[email protected]>
1 parent 812a1c3 commit c229d57

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

kernel/rcu/rcuscale.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -889,14 +889,12 @@ kfree_scale_init(void)
889889

890890
if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) {
891891
pr_alert("ERROR: call_rcu() CBs are not being lazy as expected!\n");
892-
WARN_ON_ONCE(1);
893892
firsterr = -1;
894893
goto unwind;
895894
}
896895

897896
if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start > 3 * HZ)) {
898897
pr_alert("ERROR: call_rcu() CBs are being too lazy!\n");
899-
WARN_ON_ONCE(1);
900898
firsterr = -1;
901899
goto unwind;
902900
}

0 commit comments

Comments
 (0)