Skip to content

Commit c281afe

Browse files
vingu-linaroIngo Molnar
authored andcommitted
thermal/cpufreq: Remove arch_update_thermal_pressure()
arch_update_thermal_pressure() aims to update fast changing signal which should be averaged using PELT filtering before being provided to the scheduler which can't make smart use of fast changing signal. cpufreq now provides the maximum freq_qos pressure on the capacity to the scheduler, which includes cpufreq cooling device. Remove the call to arch_update_thermal_pressure() in cpufreq cooling device as this is handled by cpufreq_get_pressure(). Signed-off-by: Vincent Guittot <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Tested-by: Lukasz Luba <[email protected]> Reviewed-by: Lukasz Luba <[email protected]> Reviewed-by: Dhruva Gole <[email protected]> Acked-by: Viresh Kumar <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent f1f8d0a commit c281afe

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/thermal/cpufreq_cooling.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
477477
unsigned long state)
478478
{
479479
struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata;
480-
struct cpumask *cpus;
481480
unsigned int frequency;
482481
int ret;
483482

@@ -494,8 +493,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
494493
ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency);
495494
if (ret >= 0) {
496495
cpufreq_cdev->cpufreq_state = state;
497-
cpus = cpufreq_cdev->policy->related_cpus;
498-
arch_update_thermal_pressure(cpus, frequency);
499496
ret = 0;
500497
}
501498

0 commit comments

Comments
 (0)