Skip to content

Commit c2d7fa2

Browse files
andy-shevwsakernel
authored andcommitted
i2c: designware-pci: Add a note about struct dw_scl_sda_cfg usage
Add a note about struct dw_scl_sda_cfg usage to discourage people of using this structure on new platforms. Instead they should try hard to put the needed information into firmware descriptions. Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Jarkko Nikula <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent d520970 commit c2d7fa2

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/i2c/busses/i2c-designware-pcidrv.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,13 @@ enum dw_pci_ctl_id_t {
3838
navi_amd,
3939
};
4040

41+
/*
42+
* This is a legacy structure to describe the hardware counters
43+
* to configure signal timings on the bus. For Device Tree platforms
44+
* one should use the respective properties and for ACPI there is
45+
* a set of ACPI methods that provide these counters. No new
46+
* platform should use this structure.
47+
*/
4148
struct dw_scl_sda_cfg {
4249
u16 ss_hcnt;
4350
u16 fs_hcnt;

0 commit comments

Comments
 (0)