Skip to content

Commit c2df75a

Browse files
chewittSteven Price
authored andcommitted
drm/panfrost: increase readl_relaxed_poll_timeout values
Amlogic SoC devices report the following errors frequently causing excessive dmesg log spam and early log rotataion, although the errors appear to be harmless as everything works fine: [ 7.202702] panfrost ffe40000.gpu: error powering up gpu L2 [ 7.203760] panfrost ffe40000.gpu: error powering up gpu shader ARM staff have advised increasing the timeout values to eliminate the errors in most normal scenarios, and testing with several different G31/G52 devices shows 20000 to be a reliable value. Fixes: f3ba912 ("drm/panfrost: Add initial panfrost driver") Suggested-by: Steven Price <[email protected]> Signed-off-by: Christian Hewitt <[email protected]> Reviewed-by: Steven Price <[email protected]> Signed-off-by: Steven Price <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 6561e0a commit c2df75a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/panfrost/panfrost_gpu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,13 +325,13 @@ void panfrost_gpu_power_on(struct panfrost_device *pfdev)
325325
/* Just turn on everything for now */
326326
gpu_write(pfdev, L2_PWRON_LO, pfdev->features.l2_present);
327327
ret = readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO,
328-
val, val == pfdev->features.l2_present, 100, 1000);
328+
val, val == pfdev->features.l2_present, 100, 20000);
329329
if (ret)
330330
dev_err(pfdev->dev, "error powering up gpu L2");
331331

332332
gpu_write(pfdev, SHADER_PWRON_LO, pfdev->features.shader_present);
333333
ret = readl_relaxed_poll_timeout(pfdev->iomem + SHADER_READY_LO,
334-
val, val == pfdev->features.shader_present, 100, 1000);
334+
val, val == pfdev->features.shader_present, 100, 20000);
335335
if (ret)
336336
dev_err(pfdev->dev, "error powering up gpu shader");
337337

0 commit comments

Comments
 (0)