Skip to content

Commit c3812b1

Browse files
committed
Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
Pull SCSI fixes from James Bottomley: "One iscsi driver fix and one core fix. The core fix is an important one because a retry efficiency update is now causing some USB devices to get the wrong size on discovery (it upset their retry logic for READ_CAPACITY_16)" * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: scsi: iscsi: Fix redundant response for ISCSI_UEVENT_GET_HOST_STATS request scsi: core: Fix command pass through retry regression
2 parents 79a1d39 + 63ca022 commit c3812b1

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

drivers/scsi/scsi_lib.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,9 @@ static int scsi_check_passthrough(struct scsi_cmnd *scmd,
210210
struct scsi_sense_hdr sshdr;
211211
enum sam_status status;
212212

213+
if (!scmd->result)
214+
return 0;
215+
213216
if (!failures)
214217
return 0;
215218

drivers/scsi/scsi_transport_iscsi.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4104,7 +4104,7 @@ iscsi_if_rx(struct sk_buff *skb)
41044104
}
41054105
do {
41064106
/*
4107-
* special case for GET_STATS:
4107+
* special case for GET_STATS, GET_CHAP and GET_HOST_STATS:
41084108
* on success - sending reply and stats from
41094109
* inside of if_recv_msg(),
41104110
* on error - fall through.
@@ -4113,6 +4113,8 @@ iscsi_if_rx(struct sk_buff *skb)
41134113
break;
41144114
if (ev->type == ISCSI_UEVENT_GET_CHAP && !err)
41154115
break;
4116+
if (ev->type == ISCSI_UEVENT_GET_HOST_STATS && !err)
4117+
break;
41164118
err = iscsi_if_send_reply(portid, nlh->nlmsg_type,
41174119
ev, sizeof(*ev));
41184120
if (err == -EAGAIN && --retries < 0) {

0 commit comments

Comments
 (0)