scsi: qla2xxx: Fix unbound sleep in fcport delete path.

Quinn Tran · martinkpetersen · commit c3b6a1d39742 · 2019-09-23T23:09:42.000-04:00
There are instances, though rare, where a LOGO request cannot be sent out and the thread in free session done can wait indefinitely. Fix this by putting an upper bound to sleep. Link: https://lore.kernel.org/r/20190912180918.6436-3-hmadhani@marvell.com Signed-off-by: Quinn Tran <qutran@marvell.com> Signed-off-by: Himanshu Madhani <hmadhani@marvell.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
@@ -1020,6 +1020,7 @@ void qlt_free_session_done(struct work_struct *work)
 
 	if (logout_started) {
 		bool traced = false;
+		u16 cnt = 0;
 
 		while (!READ_ONCE(sess->logout_completed)) {
 			if (!traced) {
@@ -1029,6 +1030,9 @@ void qlt_free_session_done(struct work_struct *work)
 				traced = true;
 			}
 			msleep(100);
+			cnt++;
+			if (cnt > 200)
+				break;
 		}
 
 		ql_dbg(ql_dbg_disc, vha, 0xf087,

Original file line number	Diff line number	Diff line change
`@@ -1020,6 +1020,7 @@ void qlt_free_session_done(struct work_struct *work)`
`1020`	`1020`
`1021`	`1021`	`if (logout_started) {`
`1022`	`1022`	`bool traced = false;`
	`1023`	`+ u16 cnt = 0;`
`1023`	`1024`
`1024`	`1025`	`while (!READ_ONCE(sess->logout_completed)) {`
`1025`	`1026`	`if (!traced) {`
`@@ -1029,6 +1030,9 @@ void qlt_free_session_done(struct work_struct *work)`
`1029`	`1030`	`traced = true;`
`1030`	`1031`	`}`
`1031`	`1032`	`msleep(100);`
	`1033`	`+ cnt++;`
	`1034`	`+ if (cnt > 200)`
	`1035`	`+ break;`
`1032`	`1036`	`}`
`1033`	`1037`
`1034`	`1038`	`ql_dbg(ql_dbg_disc, vha, 0xf087,`