Skip to content

Commit c3b9d21

Browse files
AngeloGioacchino Del RegnoChun-Kuang Hu
authored andcommitted
drm/mediatek: dp: Move AUX_P0 setting to mtk_dp_initialize_aux_settings()
Move the register write to MTK_DP_AUX_P0_3690 to set the AUX reply mode to function mtk_dp_initialize_aux_settings(), as this is effectively part of the DPTX AUX setup sequence. Signed-off-by: AngeloGioacchino Del Regno <[email protected]> Tested-by: Chen-Yu Tsai <[email protected]> Reviewed-by: CK Hu <[email protected]> Reviewed-by: Alexandre Mergnat <[email protected]> Link: https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/ Signed-off-by: Chun-Kuang Hu <[email protected]>
1 parent 214a094 commit c3b9d21

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

drivers/gpu/drm/mediatek/mtk_dp.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,6 +1009,11 @@ static void mtk_dp_initialize_aux_settings(struct mtk_dp *mtk_dp)
10091009
mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_37C8,
10101010
MTK_ATOP_EN_AUX_TX_P0,
10111011
MTK_ATOP_EN_AUX_TX_P0);
1012+
1013+
/* Set complete reply mode for AUX */
1014+
mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_3690,
1015+
RX_REPLY_COMPLETE_MODE_AUX_TX_P0,
1016+
RX_REPLY_COMPLETE_MODE_AUX_TX_P0);
10121017
}
10131018

10141019
static void mtk_dp_initialize_digital_settings(struct mtk_dp *mtk_dp)
@@ -1826,10 +1831,6 @@ static void mtk_dp_init_port(struct mtk_dp *mtk_dp)
18261831
mtk_dp_initialize_settings(mtk_dp);
18271832
mtk_dp_initialize_aux_settings(mtk_dp);
18281833
mtk_dp_initialize_digital_settings(mtk_dp);
1829-
1830-
mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_3690,
1831-
RX_REPLY_COMPLETE_MODE_AUX_TX_P0,
1832-
RX_REPLY_COMPLETE_MODE_AUX_TX_P0);
18331834
mtk_dp_initialize_hpd_detect_settings(mtk_dp);
18341835

18351836
mtk_dp_digital_sw_reset(mtk_dp);

0 commit comments

Comments
 (0)