Skip to content

Commit c3d7f3e

Browse files
committed
dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
Move properties common to all DPU DT nodes to the dpu-common.yaml. Note, this removes description of individual DPU port@ nodes. However such definitions add no additional value. The reg values do not correspond to hardware INTF indices. The driver discovers and binds these ports not paying any care for the order of these items. Thus just leave the reference to graph.yaml#/properties/ports and the description. Reviewed-by: Rob Herring <[email protected]> Signed-off-by: Dmitry Baryshkov <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/508384/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dmitry Baryshkov <[email protected]>
1 parent 4116c9a commit c3d7f3e

File tree

6 files changed

+62
-203
lines changed

6 files changed

+62
-203
lines changed
Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
%YAML 1.2
2+
---
3+
$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml#
4+
$schema: http://devicetree.org/meta-schemas/core.yaml#
5+
6+
title: Qualcomm Display DPU common properties
7+
8+
maintainers:
9+
- Krishna Manikandan <[email protected]>
10+
- Dmitry Baryshkov <[email protected]>
11+
- Rob Clark <[email protected]>
12+
13+
description: |
14+
Common properties for QCom DPU display controller.
15+
16+
properties:
17+
interrupts:
18+
maxItems: 1
19+
20+
power-domains:
21+
maxItems: 1
22+
23+
operating-points-v2: true
24+
opp-table:
25+
type: object
26+
27+
ports:
28+
$ref: /schemas/graph.yaml#/properties/ports
29+
description: |
30+
Contains the list of output ports from DPU device. These ports
31+
connect to interfaces that are external to the DPU hardware,
32+
such as DSI, DP etc.
33+
34+
patternProperties:
35+
"^port@[0-9a-f]+$":
36+
$ref: /schemas/graph.yaml#/properties/port
37+
38+
# at least one port is required
39+
required:
40+
- port@0
41+
42+
required:
43+
- compatible
44+
- reg
45+
- reg-names
46+
- clocks
47+
- interrupts
48+
- power-domains
49+
- operating-points-v2
50+
- ports
51+
52+
additionalProperties: true

Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml

Lines changed: 2 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,9 @@ properties:
6161
patternProperties:
6262
"^display-controller@[0-9a-f]+$":
6363
type: object
64+
$ref: /schemas/display/msm/dpu-common.yaml#
6465
description: Node containing the properties of DPU.
65-
additionalProperties: false
66+
unevaluatedProperties: false
6667

6768
properties:
6869
compatible:
@@ -99,47 +100,6 @@ patternProperties:
99100
- const: core
100101
- const: vsync
101102

102-
interrupts:
103-
maxItems: 1
104-
105-
power-domains:
106-
maxItems: 1
107-
108-
operating-points-v2: true
109-
opp-table:
110-
type: object
111-
112-
ports:
113-
$ref: /schemas/graph.yaml#/properties/ports
114-
description: |
115-
Contains the list of output ports from DPU device. These ports
116-
connect to interfaces that are external to the DPU hardware,
117-
such as DSI, DP etc. Each output port contains an endpoint that
118-
describes how it is connected to an external interface.
119-
120-
properties:
121-
port@0:
122-
$ref: /schemas/graph.yaml#/properties/port
123-
description: DPU_INTF1 (DSI1)
124-
125-
port@1:
126-
$ref: /schemas/graph.yaml#/properties/port
127-
description: DPU_INTF2 (DSI2)
128-
129-
required:
130-
- port@0
131-
- port@1
132-
133-
required:
134-
- compatible
135-
- reg
136-
- reg-names
137-
- clocks
138-
- interrupts
139-
- power-domains
140-
- operating-points-v2
141-
- ports
142-
143103
required:
144104
- compatible
145105
- reg

Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml

Lines changed: 2 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,9 @@ properties:
7373
patternProperties:
7474
"^display-controller@[0-9a-f]+$":
7575
type: object
76+
$ref: /schemas/display/msm/dpu-common.yaml#
7677
description: Node containing the properties of DPU.
77-
additionalProperties: false
78+
unevaluatedProperties: false
7879

7980
properties:
8081
compatible:
@@ -107,42 +108,6 @@ patternProperties:
107108
- const: lut
108109
- const: vsync
109110

110-
interrupts:
111-
maxItems: 1
112-
113-
power-domains:
114-
maxItems: 1
115-
116-
operating-points-v2: true
117-
opp-table:
118-
type: object
119-
120-
ports:
121-
$ref: /schemas/graph.yaml#/properties/ports
122-
description: |
123-
Contains the list of output ports from DPU device. These ports
124-
connect to interfaces that are external to the DPU hardware,
125-
such as DSI. Each output port contains an endpoint that
126-
describes how it is connected to an external interface.
127-
128-
properties:
129-
port@0:
130-
$ref: /schemas/graph.yaml#/properties/port
131-
description: DPU_INTF1 (DSI1)
132-
133-
required:
134-
- port@0
135-
136-
required:
137-
- compatible
138-
- reg
139-
- reg-names
140-
- clocks
141-
- interrupts
142-
- power-domains
143-
- operating-points-v2
144-
- ports
145-
146111
required:
147112
- compatible
148113
- reg

Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,9 @@ properties:
7272
patternProperties:
7373
"^display-controller@[0-9a-f]+$":
7474
type: object
75+
$ref: /schemas/display/msm/dpu-common.yaml#
7576
description: Node containing the properties of DPU.
76-
additionalProperties: false
77+
unevaluatedProperties: false
7778

7879
properties:
7980
compatible:
@@ -108,46 +109,6 @@ patternProperties:
108109
- const: core
109110
- const: vsync
110111

111-
interrupts:
112-
maxItems: 1
113-
114-
power-domains:
115-
maxItems: 1
116-
117-
operating-points-v2: true
118-
opp-table:
119-
type: object
120-
121-
ports:
122-
$ref: /schemas/graph.yaml#/properties/ports
123-
description: |
124-
Contains the list of output ports from DPU device. These ports
125-
connect to interfaces that are external to the DPU hardware,
126-
such as DSI, DP etc. Each output port contains an endpoint that
127-
describes how it is connected to an external interface.
128-
129-
properties:
130-
port@0:
131-
$ref: /schemas/graph.yaml#/properties/port
132-
description: DPU_INTF1 (DSI1)
133-
134-
port@2:
135-
$ref: /schemas/graph.yaml#/properties/port
136-
description: DPU_INTF0 (DP)
137-
138-
required:
139-
- port@0
140-
141-
required:
142-
- compatible
143-
- reg
144-
- reg-names
145-
- clocks
146-
- interrupts
147-
- power-domains
148-
- operating-points-v2
149-
- ports
150-
151112
required:
152113
- compatible
153114
- reg

Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,9 @@ properties:
7171
patternProperties:
7272
"^display-controller@[0-9a-f]+$":
7373
type: object
74+
$ref: /schemas/display/msm/dpu-common.yaml#
7475
description: Node containing the properties of DPU.
75-
additionalProperties: false
76+
unevaluatedProperties: false
7677

7778
properties:
7879
compatible:
@@ -106,46 +107,6 @@ patternProperties:
106107
- const: core
107108
- const: vsync
108109

109-
interrupts:
110-
maxItems: 1
111-
112-
power-domains:
113-
maxItems: 1
114-
115-
operating-points-v2: true
116-
opp-table:
117-
type: object
118-
119-
ports:
120-
$ref: /schemas/graph.yaml#/properties/ports
121-
description: |
122-
Contains the list of output ports from DPU device. These ports
123-
connect to interfaces that are external to the DPU hardware,
124-
such as DSI, DP etc. Each output port contains an endpoint that
125-
describes how it is connected to an external interface.
126-
127-
properties:
128-
port@0:
129-
$ref: /schemas/graph.yaml#/properties/port
130-
description: DPU_INTF1 (DSI)
131-
132-
port@1:
133-
$ref: /schemas/graph.yaml#/properties/port
134-
description: DPU_INTF5 (EDP)
135-
136-
required:
137-
- port@0
138-
139-
required:
140-
- compatible
141-
- reg
142-
- reg-names
143-
- clocks
144-
- interrupts
145-
- power-domains
146-
- operating-points-v2
147-
- ports
148-
149110
required:
150111
- compatible
151112
- reg

Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml

Lines changed: 2 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,9 @@ properties:
7474
patternProperties:
7575
"^display-controller@[0-9a-f]+$":
7676
type: object
77+
$ref: /schemas/display/msm/dpu-common.yaml#
7778
description: Node containing the properties of DPU.
78-
additionalProperties: false
79+
unevaluatedProperties: false
7980

8081
properties:
8182
compatible:
@@ -108,47 +109,6 @@ patternProperties:
108109
- const: core
109110
- const: vsync
110111

111-
interrupts:
112-
maxItems: 1
113-
114-
power-domains:
115-
maxItems: 1
116-
117-
operating-points-v2: true
118-
opp-table:
119-
type: object
120-
121-
ports:
122-
$ref: /schemas/graph.yaml#/properties/ports
123-
description: |
124-
Contains the list of output ports from DPU device. These ports
125-
connect to interfaces that are external to the DPU hardware,
126-
such as DSI, DP etc. Each output port contains an endpoint that
127-
describes how it is connected to an external interface.
128-
129-
properties:
130-
port@0:
131-
$ref: /schemas/graph.yaml#/properties/port
132-
description: DPU_INTF1 (DSI1)
133-
134-
port@1:
135-
$ref: /schemas/graph.yaml#/properties/port
136-
description: DPU_INTF2 (DSI2)
137-
138-
required:
139-
- port@0
140-
- port@1
141-
142-
required:
143-
- compatible
144-
- reg
145-
- reg-names
146-
- clocks
147-
- interrupts
148-
- power-domains
149-
- operating-points-v2
150-
- ports
151-
152112
required:
153113
- compatible
154114
- reg

0 commit comments

Comments
 (0)