Skip to content

Commit c479017

Browse files
imirkinrobclark
authored andcommitted
drm/msm: avoid double-attaching hdmi/edp bridges
Each of hdmi and edp are already attached in msm_*_bridge_init. A second attachment returns -EBUSY, failing the driver load. Tested with HDMI on IFC6410 (APQ8064 / MDP4), but eDP case should be analogous. Fixes: 3ef2f11 (drm/msm: Use drm_attach_bridge() to attach a bridge to an encoder) Cc: Boris Brezillon <[email protected]> Signed-off-by: Ilia Mirkin <[email protected]> Reviewed-by: Rob Clark <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> Tested-by: Bjorn Andersson <[email protected]> (hdmi part) Reviewed-by: Bjorn Andersson <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent de3916c commit c479017

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

drivers/gpu/drm/msm/edp/edp.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,6 @@ int msm_edp_modeset_init(struct msm_edp *edp, struct drm_device *dev,
178178
goto fail;
179179
}
180180

181-
ret = drm_bridge_attach(encoder, edp->bridge, NULL);
182-
if (ret)
183-
goto fail;
184-
185181
priv->bridges[priv->num_bridges++] = edp->bridge;
186182
priv->connectors[priv->num_connectors++] = edp->connector;
187183

drivers/gpu/drm/msm/hdmi/hdmi.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,10 +327,6 @@ int msm_hdmi_modeset_init(struct hdmi *hdmi,
327327
goto fail;
328328
}
329329

330-
ret = drm_bridge_attach(encoder, hdmi->bridge, NULL);
331-
if (ret)
332-
goto fail;
333-
334330
priv->bridges[priv->num_bridges++] = hdmi->bridge;
335331
priv->connectors[priv->num_connectors++] = hdmi->connector;
336332

0 commit comments

Comments
 (0)