r8169: enable EEE at 2.5G per default on RTL8125B

hkallweit · lunn · commit c4e64095c00c · 2024-10-20T11:06:47.000-05:00
Register a6d/12 is shadowing register MDIO_AN_EEE_ADV2. So this line
disables advertisement of EEE at 2.5G. Latest vendor driver r8125
doesn't do this (any longer?), so this mode seems to be safe.
EEE saves quite some energy, therefore enable this mode per default.

Signed-off-by: Heiner Kallweit &lt;hkallweit1@gmail.com&gt;
Reviewed-by: Simon Horman &lt;horms@kernel.org&gt;
Message-ID: &lt;95dd5a0c-09ea-4847-94d9-b7aa3063e8ff@gmail.com&gt;
Signed-off-by: Andrew Lunn &lt;andrew@lunn.ch&gt;
diff --git a/drivers/net/ethernet/realtek/r8169_phy_config.c b/drivers/net/ethernet/realtek/r8169_phy_config.c
@@ -99,7 +99,6 @@ static void rtl8125a_config_eee_phy(struct phy_device *phydev)
 
 static void rtl8125b_config_eee_phy(struct phy_device *phydev)
 {
-	phy_modify_paged(phydev, 0xa6d, 0x12, 0x0001, 0x0000);
 	phy_modify_paged(phydev, 0xa6d, 0x14, 0x0010, 0x0000);
 	phy_modify_paged(phydev, 0xa42, 0x14, 0x0080, 0x0000);
 	phy_modify_paged(phydev, 0xa4a, 0x11, 0x0200, 0x0000);

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,6 @@ static void rtl8125a_config_eee_phy(struct phy_device *phydev)`
`99`	`99`
`100`	`100`	`static void rtl8125b_config_eee_phy(struct phy_device *phydev)`
`101`	`101`	`{`
`102`		`- phy_modify_paged(phydev, 0xa6d, 0x12, 0x0001, 0x0000);`
`103`	`102`	`phy_modify_paged(phydev, 0xa6d, 0x14, 0x0010, 0x0000);`
`104`	`103`	`phy_modify_paged(phydev, 0xa42, 0x14, 0x0080, 0x0000);`
`105`	`104`	`phy_modify_paged(phydev, 0xa4a, 0x11, 0x0200, 0x0000);`