Skip to content

Commit c57dbca

Browse files
Minghao Chibroonie
authored andcommitted
drivers/regulator: remove redundant ret variable
Return value from twlreg_write() directly instead of taking this in another redundant variable. Reported-by: Zeal Robot <[email protected]> Signed-off-by: Minghao Chi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 8d9f738 commit c57dbca

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

drivers/regulator/twl-regulator.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -196,34 +196,28 @@ static int twl4030reg_enable(struct regulator_dev *rdev)
196196
{
197197
struct twlreg_info *info = rdev_get_drvdata(rdev);
198198
int grp;
199-
int ret;
200199

201200
grp = twlreg_grp(rdev);
202201
if (grp < 0)
203202
return grp;
204203

205204
grp |= P1_GRP_4030;
206205

207-
ret = twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_GRP, grp);
208-
209-
return ret;
206+
return twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_GRP, grp);
210207
}
211208

212209
static int twl4030reg_disable(struct regulator_dev *rdev)
213210
{
214211
struct twlreg_info *info = rdev_get_drvdata(rdev);
215212
int grp;
216-
int ret;
217213

218214
grp = twlreg_grp(rdev);
219215
if (grp < 0)
220216
return grp;
221217

222218
grp &= ~(P1_GRP_4030 | P2_GRP_4030 | P3_GRP_4030);
223219

224-
ret = twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_GRP, grp);
225-
226-
return ret;
220+
return twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_GRP, grp);
227221
}
228222

229223
static int twl4030reg_get_status(struct regulator_dev *rdev)

0 commit comments

Comments
 (0)