Skip to content

Commit c588f7d

Browse files
bebarinoAbhinav Kumar
authored andcommitted
drm/msm: Add newlines to some debug prints
These debug prints are missing newlines, leading to multiple messages being printed on one line and hard to read logs. Add newlines to have the debug prints on separate lines. The DBG macro used to add a newline, but I missed that while migrating to drm_dbg wrappers. Fixes: 7cb017d ("drm/msm: Move FB debug prints to drm_dbg_state()") Fixes: 721c6e0 ("drm/msm: Move vblank debug prints to drm_dbg_vbl()") Signed-off-by: Stephen Boyd <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Abhinav Kumar <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/584769/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Abhinav Kumar <[email protected]>
1 parent e86750b commit c588f7d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

drivers/gpu/drm/msm/msm_fb.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb,
8989

9090
for (i = 0; i < n; i++) {
9191
ret = msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]);
92-
drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)",
92+
drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)\n",
9393
fb->base.id, i, msm_fb->iova[i], ret);
9494
if (ret)
9595
return ret;
@@ -176,7 +176,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev,
176176
const struct msm_format *format;
177177
int ret, i, n;
178178

179-
drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)",
179+
drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)\n",
180180
mode_cmd, mode_cmd->width, mode_cmd->height,
181181
(char *)&mode_cmd->pixel_format);
182182

@@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev,
232232

233233
refcount_set(&msm_fb->dirtyfb, 1);
234234

235-
drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb);
235+
drm_dbg_state(dev, "create: FB ID: %d (%p)\n", fb->base.id, fb);
236236

237237
return fb;
238238

drivers/gpu/drm/msm/msm_kms.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ int msm_crtc_enable_vblank(struct drm_crtc *crtc)
149149
struct msm_kms *kms = priv->kms;
150150
if (!kms)
151151
return -ENXIO;
152-
drm_dbg_vbl(dev, "crtc=%u", crtc->base.id);
152+
drm_dbg_vbl(dev, "crtc=%u\n", crtc->base.id);
153153
return vblank_ctrl_queue_work(priv, crtc, true);
154154
}
155155

@@ -160,7 +160,7 @@ void msm_crtc_disable_vblank(struct drm_crtc *crtc)
160160
struct msm_kms *kms = priv->kms;
161161
if (!kms)
162162
return;
163-
drm_dbg_vbl(dev, "crtc=%u", crtc->base.id);
163+
drm_dbg_vbl(dev, "crtc=%u\n", crtc->base.id);
164164
vblank_ctrl_queue_work(priv, crtc, false);
165165
}
166166

0 commit comments

Comments
 (0)