Skip to content

Commit c62e7ac

Browse files
committed
net: genetlink: Move initialization to core_initcall
The generic netlink is initialized far after the netlink protocol itself at subsys_initcall. The devlink is initialized at the same level, but after, as shown by a disassembly of the vmlinux: [ ... ] 374 ffff8000115f22c0 <__initcall_devlink_init4>: 375 ffff8000115f22c4 <__initcall_genl_init4>: [ ... ] The function devlink_init() calls genl_register_family() before the generic netlink subsystem is initialized. As the generic netlink initcall level is set since 2005, it seems that was not a problem, but now we have the thermal framework initialized at the core_initcall level which creates the generic netlink family and sends a notification which leads to a subtle memory corruption only detectable when the CONFIG_INIT_ON_ALLOC_DEFAULT_ON option is set with the earlycon at init time. The thermal framework needs to be initialized early in order to begin the mitigation as soon as possible. Moving it to postcore_initcall is acceptable. This patch changes the initialization level for the generic netlink family to the core_initcall and comes after the netlink protocol initialization. Signed-off-by: Daniel Lezcano <[email protected]> Acked-by: David S. Miller <[email protected]> Tested-by: Marek Szyprowski <[email protected]> Reviewed-by: Amit Kucheria <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 947d85f commit c62e7ac

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/netlink/genetlink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1263,7 +1263,7 @@ static int __init genl_init(void)
12631263
panic("GENL: Cannot register controller: %d\n", err);
12641264
}
12651265

1266-
subsys_initcall(genl_init);
1266+
core_initcall(genl_init);
12671267

12681268
static int genlmsg_mcast(struct sk_buff *skb, u32 portid, unsigned long group,
12691269
gfp_t flags)

0 commit comments

Comments
 (0)