Skip to content

Commit c65b229

Browse files
joehattorigregkh
authored andcommitted
spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe()
spmi_controller_probe() assigns a parent device and an OF node to an SPMI controller. However, the operations are not needed as they are already assigned in spmi_controller_alloc(). Thus, remove the duplicated assignments. An unnecessary OF node reference acquisition is also dropped by this patch. Signed-off-by: Joe Hattori <[email protected]> Suggested-by: Stephen Boyd <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent bc32bbd commit c65b229

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/spmi/hisi-spmi-controller.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -300,9 +300,6 @@ static int spmi_controller_probe(struct platform_device *pdev)
300300

301301
spin_lock_init(&spmi_controller->lock);
302302

303-
ctrl->dev.parent = pdev->dev.parent;
304-
ctrl->dev.of_node = of_node_get(pdev->dev.of_node);
305-
306303
/* Callbacks */
307304
ctrl->read_cmd = spmi_read_cmd;
308305
ctrl->write_cmd = spmi_write_cmd;

0 commit comments

Comments
 (0)