Skip to content

Commit c6ddd6e

Browse files
nxpfrankliShawn Guo
authored andcommitted
arm64: dts: imx8-ss-conn: fix usdhc wrong lpcg clock order
The actual clock show wrong frequency: echo on >/sys/devices/platform/bus\@5b000000/5b010000.mmc/power/control cat /sys/kernel/debug/mmc0/ios clock: 200000000 Hz actual clock: 166000000 Hz ^^^^^^^^^ ..... According to sdhc0_lpcg: clock-controller@5b200000 { compatible = "fsl,imx8qxp-lpcg"; reg = <0x5b200000 0x10000>; #clock-cells = <1>; clocks = <&clk IMX_SC_R_SDHC_0 IMX_SC_PM_CLK_PER>, <&conn_ipg_clk>, <&conn_axi_clk>; clock-indices = <IMX_LPCG_CLK_0>, <IMX_LPCG_CLK_4>, <IMX_LPCG_CLK_5>; clock-output-names = "sdhc0_lpcg_per_clk", "sdhc0_lpcg_ipg_clk", "sdhc0_lpcg_ahb_clk"; power-domains = <&pd IMX_SC_R_SDHC_0>; } "per_clk" should be IMX_LPCG_CLK_0 instead of IMX_LPCG_CLK_5. After correct clocks order: echo on >/sys/devices/platform/bus\@5b000000/5b010000.mmc/power/control cat /sys/kernel/debug/mmc0/ios clock: 200000000 Hz actual clock: 198000000 Hz ^^^^^^^^ ... Fixes: 16c4ea7 ("arm64: dts: imx8: switch to new lpcg clock binding") Signed-off-by: Frank Li <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent 6f8e0ac commit c6ddd6e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ conn_subsys: bus@5b000000 {
6767
interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
6868
reg = <0x5b010000 0x10000>;
6969
clocks = <&sdhc0_lpcg IMX_LPCG_CLK_4>,
70-
<&sdhc0_lpcg IMX_LPCG_CLK_0>,
71-
<&sdhc0_lpcg IMX_LPCG_CLK_5>;
70+
<&sdhc0_lpcg IMX_LPCG_CLK_5>,
71+
<&sdhc0_lpcg IMX_LPCG_CLK_0>;
7272
clock-names = "ipg", "ahb", "per";
7373
power-domains = <&pd IMX_SC_R_SDHC_0>;
7474
status = "disabled";
@@ -78,8 +78,8 @@ conn_subsys: bus@5b000000 {
7878
interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
7979
reg = <0x5b020000 0x10000>;
8080
clocks = <&sdhc1_lpcg IMX_LPCG_CLK_4>,
81-
<&sdhc1_lpcg IMX_LPCG_CLK_0>,
82-
<&sdhc1_lpcg IMX_LPCG_CLK_5>;
81+
<&sdhc1_lpcg IMX_LPCG_CLK_5>,
82+
<&sdhc1_lpcg IMX_LPCG_CLK_0>;
8383
clock-names = "ipg", "ahb", "per";
8484
power-domains = <&pd IMX_SC_R_SDHC_1>;
8585
fsl,tuning-start-tap = <20>;
@@ -91,8 +91,8 @@ conn_subsys: bus@5b000000 {
9191
interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>;
9292
reg = <0x5b030000 0x10000>;
9393
clocks = <&sdhc2_lpcg IMX_LPCG_CLK_4>,
94-
<&sdhc2_lpcg IMX_LPCG_CLK_0>,
95-
<&sdhc2_lpcg IMX_LPCG_CLK_5>;
94+
<&sdhc2_lpcg IMX_LPCG_CLK_5>,
95+
<&sdhc2_lpcg IMX_LPCG_CLK_0>;
9696
clock-names = "ipg", "ahb", "per";
9797
power-domains = <&pd IMX_SC_R_SDHC_2>;
9898
status = "disabled";

0 commit comments

Comments
 (0)