Skip to content

Commit c724f77

Browse files
jhovoldgregkh
authored andcommitted
staging: rtl8712: fix interface sanity check
Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: 2865d42 ("staging: r8712u: Add the new driver to the mainline kernel") Cc: stable <[email protected]> # 2.6.37 Signed-off-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 74ca341 commit c724f77

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/staging/rtl8712/usb_intf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ static uint r8712_usb_dvobj_init(struct _adapter *padapter)
247247

248248
pdvobjpriv->padapter = padapter;
249249
padapter->eeprom_address_size = 6;
250-
phost_iface = &pintf->altsetting[0];
250+
phost_iface = pintf->cur_altsetting;
251251
piface_desc = &phost_iface->desc;
252252
pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;
253253
if (pusbd->speed == USB_SPEED_HIGH) {

0 commit comments

Comments
 (0)