Skip to content

Commit c7622a4

Browse files
rtc: m41t80: reduce verbosity
The driver currently uses dev_err for messages that have a very low probability of being read by the user as the error will probably never happen and the systems with the RTC probably don't have any user able to read the message. Moreover, the only user action after getting this message is the restart the action so drop the level to dev_dbg. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
1 parent 1a7ed2f commit c7622a4

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

drivers/rtc/rtc-m41t80.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ static int m41t80_rtc_read_time(struct device *dev, struct rtc_time *tm)
212212
err = i2c_smbus_read_i2c_block_data(client, M41T80_REG_SSEC,
213213
sizeof(buf), buf);
214214
if (err < 0) {
215-
dev_err(&client->dev, "Unable to read date\n");
215+
dev_dbg(&client->dev, "Unable to read date\n");
216216
return err;
217217
}
218218

@@ -268,35 +268,35 @@ static int m41t80_rtc_set_time(struct device *dev, struct rtc_time *in_tm)
268268
err = i2c_smbus_write_i2c_block_data(client, M41T80_REG_SSEC,
269269
sizeof(buf), buf);
270270
if (err < 0) {
271-
dev_err(&client->dev, "Unable to write to date registers\n");
271+
dev_dbg(&client->dev, "Unable to write to date registers\n");
272272
return err;
273273
}
274274
if (flags & M41T80_FLAGS_OF) {
275275
/* OF cannot be immediately reset: oscillator has to be restarted. */
276276
dev_warn(&client->dev, "OF bit is still set, kickstarting clock.\n");
277277
err = i2c_smbus_write_byte_data(client, M41T80_REG_SEC, M41T80_SEC_ST);
278278
if (err < 0) {
279-
dev_err(&client->dev, "Can't set ST bit\n");
279+
dev_dbg(&client->dev, "Can't set ST bit\n");
280280
return err;
281281
}
282282
err = i2c_smbus_write_byte_data(client, M41T80_REG_SEC, flags & ~M41T80_SEC_ST);
283283
if (err < 0) {
284-
dev_err(&client->dev, "Can't clear ST bit\n");
284+
dev_dbg(&client->dev, "Can't clear ST bit\n");
285285
return err;
286286
}
287287
/* oscillator must run for 4sec before we attempt to reset OF bit */
288288
msleep(4000);
289289
/* Clear the OF bit of Flags Register */
290290
err = i2c_smbus_write_byte_data(client, M41T80_REG_FLAGS, flags & ~M41T80_FLAGS_OF);
291291
if (err < 0) {
292-
dev_err(&client->dev, "Unable to write flags register\n");
292+
dev_dbg(&client->dev, "Unable to write flags register\n");
293293
return err;
294294
}
295295
flags = i2c_smbus_read_byte_data(client, M41T80_REG_FLAGS);
296296
if (flags < 0) {
297297
return flags;
298298
} else if (flags & M41T80_FLAGS_OF) {
299-
dev_err(&client->dev, "Can't clear the OF bit check battery\n");
299+
dev_dbg(&client->dev, "Can't clear the OF bit check battery\n");
300300
return err;
301301
}
302302
}
@@ -336,7 +336,7 @@ static int m41t80_alarm_irq_enable(struct device *dev, unsigned int enabled)
336336

337337
retval = i2c_smbus_write_byte_data(client, M41T80_REG_ALARM_MON, flags);
338338
if (retval < 0) {
339-
dev_err(dev, "Unable to enable alarm IRQ %d\n", retval);
339+
dev_dbg(dev, "Unable to enable alarm IRQ %d\n", retval);
340340
return retval;
341341
}
342342
return 0;
@@ -361,7 +361,7 @@ static int m41t80_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
361361
err = i2c_smbus_write_byte_data(client, M41T80_REG_ALARM_MON,
362362
ret & ~(M41T80_ALMON_AFE));
363363
if (err < 0) {
364-
dev_err(dev, "Unable to clear AFE bit\n");
364+
dev_dbg(dev, "Unable to clear AFE bit\n");
365365
return err;
366366
}
367367

@@ -375,7 +375,7 @@ static int m41t80_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
375375
err = i2c_smbus_write_byte_data(client, M41T80_REG_FLAGS,
376376
ret & ~(M41T80_FLAGS_AF));
377377
if (err < 0) {
378-
dev_err(dev, "Unable to clear AF bit\n");
378+
dev_dbg(dev, "Unable to clear AF bit\n");
379379
return err;
380380
}
381381

0 commit comments

Comments
 (0)