Skip to content

Commit c78b9a9

Browse files
Naveenaidubjorn-helgaas
authored andcommitted
PCI: xgene: Use PCI_ERROR_RESPONSE to identify config read errors
Include PCI_ERROR_RESPONSE along with 0xffffffff in the comment about identifying config read errors. This makes checks for config read errors easier to find. Comment change only. Link: https://lore.kernel.org/r/388b9733bd55394581c447be9f3df42ca2c9759c.1637243717.git.naveennaidu479@gmail.com Signed-off-by: Naveen Naidu <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent 14e04d0 commit c78b9a9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/pci/controller/pci-xgene.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,11 +171,11 @@ static int xgene_pcie_config_read32(struct pci_bus *bus, unsigned int devfn,
171171
return PCIBIOS_DEVICE_NOT_FOUND;
172172

173173
/*
174-
* The v1 controller has a bug in its Configuration Request
175-
* Retry Status (CRS) logic: when CRS Software Visibility is
176-
* enabled and we read the Vendor and Device ID of a non-existent
177-
* device, the controller fabricates return data of 0xFFFF0001
178-
* ("device exists but is not ready") instead of 0xFFFFFFFF
174+
* The v1 controller has a bug in its Configuration Request Retry
175+
* Status (CRS) logic: when CRS Software Visibility is enabled and
176+
* we read the Vendor and Device ID of a non-existent device, the
177+
* controller fabricates return data of 0xFFFF0001 ("device exists
178+
* but is not ready") instead of 0xFFFFFFFF (PCI_ERROR_RESPONSE)
179179
* ("device does not exist"). This causes the PCI core to retry
180180
* the read until it times out. Avoid this by not claiming to
181181
* support CRS SV.

0 commit comments

Comments
 (0)