Skip to content

Commit c7b7c64

Browse files
ozshlomoSaeed Mahameed
authored andcommitted
net/mlx5e: TC, Remove error message log print
The cited commit attempts to update the hw stats when dumping tc actions. However, the driver may be called to update the stats of a police action that may not be in hardware. In such cases the driver will fail to lookup the police action object and will output an error message both to extack and dmesg. The dmesg error is confusing as it may not indicate an actual error. Remove the dmesg error. Fixes: 2b68d65 ("net/mlx5e: TC, support per action stats") Signed-off-by: Oz Shlomo <[email protected]> Reviewed-by: Paul Blakey <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent b23bf10 commit c7b7c64

File tree

1 file changed

+0
-1
lines changed
  • drivers/net/ethernet/mellanox/mlx5/core/en/tc/act

1 file changed

+0
-1
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@ tc_act_police_stats(struct mlx5e_priv *priv,
178178
meter = mlx5e_tc_meter_get(priv->mdev, &params);
179179
if (IS_ERR(meter)) {
180180
NL_SET_ERR_MSG_MOD(fl_act->extack, "Failed to get flow meter");
181-
mlx5_core_err(priv->mdev, "Failed to get flow meter %d\n", params.index);
182181
return PTR_ERR(meter);
183182
}
184183

0 commit comments

Comments
 (0)