Skip to content

Commit c7c4495

Browse files
pbrkrPaolo Abeni
authored andcommitted
net: ravb: Fix GbEth jumbo packet RX checksum handling
Sending a 7kB ping packet to the RZ/G2L in v6.9-rc2 causes the following backtrace: WARNING: CPU: 0 PID: 0 at include/linux/skbuff.h:3127 skb_trim+0x30/0x38 Hardware name: Renesas SMARC EVK based on r9a07g044l2 (DT) pc : skb_trim+0x30/0x38 lr : ravb_rx_csum_gbeth+0x40/0x90 Call trace: skb_trim+0x30/0x38 ravb_rx_gbeth+0x56c/0x5cc ravb_poll+0xa0/0x204 __napi_poll+0x38/0x17c This is caused by ravb_rx_gbeth() calling ravb_rx_csum_gbeth() with the wrong skb for a packet which spans multiple descriptors. To fix this, use the correct skb. Fixes: c2da940 ("ravb: Add Rx checksum offload support for GbEth") Signed-off-by: Paul Barker <[email protected]> Reviewed-by: Sergey Shtylyov <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent a892493 commit c7c4495

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/renesas/ravb_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -843,7 +843,7 @@ static bool ravb_rx_gbeth(struct net_device *ndev, int *quota, int q)
843843
priv->rx_1st_skb->protocol =
844844
eth_type_trans(priv->rx_1st_skb, ndev);
845845
if (ndev->features & NETIF_F_RXCSUM)
846-
ravb_rx_csum_gbeth(skb);
846+
ravb_rx_csum_gbeth(priv->rx_1st_skb);
847847
napi_gro_receive(&priv->napi[q],
848848
priv->rx_1st_skb);
849849
rx_packets++;

0 commit comments

Comments
 (0)