Skip to content

Commit c7d216e

Browse files
Christoph Hellwigtytso
authored andcommitted
fs: remove the access_ok() check in ioctl_fiemap
access_ok just checks we are fed a proper user pointer. We also do that in copy_to_user itself, so no need to do this early. Signed-off-by: Christoph Hellwig <[email protected]> Reviewed-by: Ritesh Harjani <[email protected]> Reviewed-by: Darrick J. Wong <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Theodore Ts'o <[email protected]>
1 parent 45dd052 commit c7d216e

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

fs/ioctl.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -213,13 +213,9 @@ static int ioctl_fiemap(struct file *filp, struct fiemap __user *ufiemap)
213213
fieinfo.fi_extents_max = fiemap.fm_extent_count;
214214
fieinfo.fi_extents_start = ufiemap->fm_extents;
215215

216-
if (fiemap.fm_extent_count != 0 &&
217-
!access_ok(fieinfo.fi_extents_start,
218-
fieinfo.fi_extents_max * sizeof(struct fiemap_extent)))
219-
return -EFAULT;
220-
221216
error = inode->i_op->fiemap(inode, &fieinfo, fiemap.fm_start,
222217
fiemap.fm_length);
218+
223219
fiemap.fm_flags = fieinfo.fi_flags;
224220
fiemap.fm_mapped_extents = fieinfo.fi_extents_mapped;
225221
if (copy_to_user(ufiemap, &fiemap, sizeof(fiemap)))

0 commit comments

Comments
 (0)