ksmbd: Remove unneeded if check in ksmbd_rdma_capable_netdev()

toblux · smfrench · commit c7f3cd1b245d · 2025-01-05T20:43:37.000-06:00
Remove the unnecessary if check and assign the result directly.

Signed-off-by: Thorsten Blum &lt;thorsten.blum@linux.dev&gt;
Acked-by: Namjae Jeon &lt;linkinjeon@kernel.org&gt;
Signed-off-by: Steve French &lt;stfrench@microsoft.com&gt;
diff --git a/fs/smb/server/transport_rdma.c b/fs/smb/server/transport_rdma.c
@@ -2283,8 +2283,7 @@ bool ksmbd_rdma_capable_netdev(struct net_device *netdev)
 
 		ibdev = ib_device_get_by_netdev(netdev, RDMA_DRIVER_UNKNOWN);
 		if (ibdev) {
-			if (rdma_frwr_is_supported(&ibdev->attrs))
-				rdma_capable = true;
+			rdma_capable = rdma_frwr_is_supported(&ibdev->attrs);
 			ib_device_put(ibdev);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -2283,8 +2283,7 @@ bool ksmbd_rdma_capable_netdev(struct net_device *netdev)`
`2283`	`2283`
`2284`	`2284`	`ibdev = ib_device_get_by_netdev(netdev, RDMA_DRIVER_UNKNOWN);`
`2285`	`2285`	`if (ibdev) {`
`2286`		`- if (rdma_frwr_is_supported(&ibdev->attrs))`
`2287`		`- rdma_capable = true;`
	`2286`	`+ rdma_capable = rdma_frwr_is_supported(&ibdev->attrs);`
`2288`	`2287`	`ib_device_put(ibdev);`
`2289`	`2288`	`}`
`2290`	`2289`	`}`