Skip to content

Commit c81aba8

Browse files
fshh520tsbogend
authored andcommitted
MIPS: Remove repetitive increase irq_err_count
commit 979934d ("[PATCH] mips: update IRQ handling for vr41xx") added a function irq_dispatch, and it'll increase irq_err_count when the get_irq callback returns a negative value, but increase irq_err_count in get_irq was not removed. And also, modpost complains once gpio-vr41xx drivers become modules. ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined! So it would be a good idea to remove repetitive increase irq_err_count in get_irq callback. Fixes: 27fdd32 ("MIPS: Update VR41xx GPIO driver to use gpiolib") Fixes: 979934d ("[PATCH] mips: update IRQ handling for vr41xx") Reported-by: k2ci <[email protected]> Signed-off-by: huhai <[email protected]> Signed-off-by: Genjian Zhang <[email protected]> Signed-off-by: Thomas Bogendoerfer <[email protected]>
1 parent a111daf commit c81aba8

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

arch/mips/vr41xx/common/icu.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -640,8 +640,6 @@ static int icu_get_irq(unsigned int irq)
640640

641641
printk(KERN_ERR "spurious ICU interrupt: %04x,%04x\n", pend1, pend2);
642642

643-
atomic_inc(&irq_err_count);
644-
645643
return -1;
646644
}
647645

drivers/gpio/gpio-vr41xx.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,6 @@ static int giu_get_irq(unsigned int irq)
217217
printk(KERN_ERR "spurious GIU interrupt: %04x(%04x),%04x(%04x)\n",
218218
maskl, pendl, maskh, pendh);
219219

220-
atomic_inc(&irq_err_count);
221-
222220
return -EINVAL;
223221
}
224222

0 commit comments

Comments
 (0)