Skip to content

Commit c82c507

Browse files
anarsoulrafaeljw
authored andcommitted
ACPICA: executer/exsystem: Don't nag user about every Stall() violating the spec
ACPICA commit 129b75516fc49fe1fd6b8c5798f86c13854630b3 Stop nagging user about every Stall() that violates the spec On my Dell XPS 15 7590 I get hundreds of these warnings after few hours of uptime: $ dmesg | grep "fix the firmware" | wc -l 261 I cannot fix the firmware and I doubt that Dell cares about 4 year old laptop either Fixes: ace8f1c ("ACPICA: executer/exsystem: Inform users about ACPI spec violation") Link: acpica/acpica@129b7551 Signed-off-by: Vasily Khoruzhick <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 632b746 commit c82c507

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

drivers/acpi/acpica/exsystem.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,15 @@ acpi_status acpi_ex_system_do_stall(u32 how_long_us)
133133
* (ACPI specifies 100 usec as max, but this gives some slack in
134134
* order to support existing BIOSs)
135135
*/
136-
ACPI_ERROR((AE_INFO,
137-
"Time parameter is too large (%u)", how_long_us));
136+
ACPI_ERROR_ONCE((AE_INFO,
137+
"Time parameter is too large (%u)",
138+
how_long_us));
138139
status = AE_AML_OPERAND_VALUE;
139140
} else {
140141
if (how_long_us > 100) {
141-
ACPI_WARNING((AE_INFO,
142-
"Time parameter %u us > 100 us violating ACPI spec, please fix the firmware.",
143-
how_long_us));
142+
ACPI_WARNING_ONCE((AE_INFO,
143+
"Time parameter %u us > 100 us violating ACPI spec, please fix the firmware.",
144+
how_long_us));
144145
}
145146
acpi_os_stall(how_long_us);
146147
}

0 commit comments

Comments
 (0)