Skip to content

Commit c85c7cd

Browse files
Colin Ian Kingpavelmachek
authored andcommitted
leds: trigger: remove redundant assignment to variable ret
The variable ret is being assigned with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Pavel Machek <[email protected]>
1 parent 9af512e commit c85c7cd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/leds/trigger/ledtrig-timer.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ static ssize_t led_delay_on_store(struct device *dev,
2828
{
2929
struct led_classdev *led_cdev = led_trigger_get_led(dev);
3030
unsigned long state;
31-
ssize_t ret = -EINVAL;
31+
ssize_t ret;
3232

3333
ret = kstrtoul(buf, 10, &state);
3434
if (ret)
@@ -53,7 +53,7 @@ static ssize_t led_delay_off_store(struct device *dev,
5353
{
5454
struct led_classdev *led_cdev = led_trigger_get_led(dev);
5555
unsigned long state;
56-
ssize_t ret = -EINVAL;
56+
ssize_t ret;
5757

5858
ret = kstrtoul(buf, 10, &state);
5959
if (ret)

0 commit comments

Comments
 (0)